Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9862)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)
Patch Set: fix Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/browser_render_process_host.cc
diff --git a/chrome/browser/renderer_host/browser_render_process_host.cc b/chrome/browser/renderer_host/browser_render_process_host.cc
index 2506617bc537d37f02e2b30665eb4513771acff7..9bf17425b7b026519761a38c92cabfd572515ac2 100644
--- a/chrome/browser/renderer_host/browser_render_process_host.cc
+++ b/chrome/browser/renderer_host/browser_render_process_host.cc
@@ -331,7 +331,7 @@ bool BrowserRenderProcessHost::Init(bool is_extensions_process,
if (!renderer_prefix.empty())
cmd_line->PrependWrapper(renderer_prefix);
AppendRendererCommandLine(cmd_line);
- cmd_line->AppendSwitchWithValue(switches::kProcessChannelID, channel_id);
+ cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
// Spawn the child process asynchronously to avoid blocking the UI thread.
// As long as there's no renderer prefix, we can use the zygote process
@@ -445,7 +445,7 @@ void BrowserRenderProcessHost::AppendRendererCommandLine(
// Pass the process type first, so it shows first in process listings.
// Extensions use a special pseudo-process type to make them distinguishable,
// even though they're just renderers.
- command_line->AppendSwitchWithValue(switches::kProcessType,
+ command_line->AppendSwitchASCII(switches::kProcessType,
extension_process_ ? switches::kExtensionProcess :
switches::kRendererProcess);
@@ -458,7 +458,7 @@ void BrowserRenderProcessHost::AppendRendererCommandLine(
// Pass on the browser locale.
const std::string locale = g_browser_process->GetApplicationLocale();
- command_line->AppendSwitchWithValue(switches::kLang, locale);
+ command_line->AppendSwitchASCII(switches::kLang, locale);
// If we run FieldTrials, we want to pass to their state to the renderer so
// that it can act in accordance with each state, or record histograms
@@ -466,8 +466,8 @@ void BrowserRenderProcessHost::AppendRendererCommandLine(
std::string field_trial_states;
FieldTrialList::StatesToString(&field_trial_states);
if (!field_trial_states.empty()) {
- command_line->AppendSwitchWithValue(switches::kForceFieldTestNameAndValue,
- field_trial_states);
+ command_line->AppendSwitchASCII(switches::kForceFieldTestNameAndValue,
+ field_trial_states);
}
BrowserChildProcessHost::SetCrashReporterCommandLine(command_line);
@@ -480,7 +480,7 @@ void BrowserRenderProcessHost::AppendRendererCommandLine(
const std::string& profile =
browser_command_line.GetSwitchValueASCII(switches::kProfile);
if (!profile.empty())
- command_line->AppendSwitchWithValue(switches::kProfile, profile);
+ command_line->AppendSwitchASCII(switches::kProfile, profile);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698