Mac/clang: First pass over unit_tests

Mac/clang: First pass over unit_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50590

[Nico, 2010-06-21 16:27:30]

(Try job not visible on rietveld 'cause `git cl patch; git try` doesn't update
rietveld)

[Evan Martin, 2010-06-21 20:54:26]

I wonder if it'd be better to do a sed job to fix all the NSString const stuff
in one huge go.

[Nico, 2010-06-21 20:57:24]

According to git gs, I found most of them already.

It was a :bufdo job with a build-target provided file list.

On Mon, Jun 21, 2010 at 1:54 PM,  <evan@chromium.org> wrote:
> I wonder if it'd be better to do a sed job to fix all the NSString const
> stuff
> in one huge go.
>
> http://codereview.chromium.org/2876002/show
>

[Mark Mentovai, 2010-06-21 21:01:15]

evan@chromium.org wrote:
> I wonder if it'd be better to do a sed job to fix all the NSString const
> stuff in one huge go.

We learned that this was a bad approach.

See the end of http://codereview.chromium.org/2769014, from where joth
had a question.

[Nico, 2010-06-23 07:28:22]

This is now green on the trybots. PTaL.

[Mark Mentovai, 2010-06-23 13:51:28]

LGTM

http://codereview.chromium.org/2876002/diff/6015/7004
File chrome/browser/cocoa/autocomplete_text_field_unittest.mm (right):

http://codereview.chromium.org/2876002/diff/6015/7004#newcode359
chrome/browser/cocoa/autocomplete_text_field_unittest.mm:359: NSString* const
kHintString(@"Type to search");
Use = instead of ().

http://codereview.chromium.org/2876002/diff/6015/7004#newcode391
chrome/browser/cocoa/autocomplete_text_field_unittest.mm:391: NSString* const
kFullString(@"Search Engine:");
Ditto here and on the next line.