Mac/clang: First pass over unit_tests

chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "app/resource_bundle.h"
 #include "base/scoped_nsobject.h"
 #import "chrome/browser/cocoa/autocomplete_text_field_cell.h"
 #import "chrome/browser/cocoa/cocoa_test_helper.h"
@@ skipping 417 matching lines @@
   EXPECT_LE(NSMaxX(iconRect1), NSMinX(iconRect0));
   EXPECT_LE(NSMaxX(labelRect), NSMinX(iconRect0));
 }
 
 // Test that the cell correctly chooses the partial keyword if there's
 // not enough room.
 TEST_F(AutocompleteTextFieldCellTest, UsesPartialKeywordIfNarrow) {
   AutocompleteTextFieldCell* cell =
       static_cast<AutocompleteTextFieldCell*>([view_ cell]);
 
-  const NSString* kFullString = @"Search Engine:";
-  const NSString* kPartialString = @"Search Eng:";
+  NSString* const kFullString = @"Search Engine:";
+  NSString* const kPartialString = @"Search Eng:";
 
   // Wide width chooses the full string, including an image on the
   // left.
   [cell setKeywordString:kFullString
            partialString:kPartialString
           availableWidth:kWidth];
   EXPECT_TRUE([cell keywordString]);
   EXPECT_TRUE([[[cell keywordString] string] hasSuffix:kFullString]);
   EXPECT_TRUE([[cell keywordString] containsAttachments]);
 
@@ skipping 20 matching lines @@
   EXPECT_TRUE([cell keywordString]);
   EXPECT_TRUE([[[cell keywordString] string] isEqualToString:kFullString]);
 }
 
 // Test that the cell drops the search hint if there is no room for
 // it.
 TEST_F(AutocompleteTextFieldCellTest, OmitsSearchHintIfNarrow) {
   AutocompleteTextFieldCell* cell =
       static_cast<AutocompleteTextFieldCell*>([view_ cell]);
 
-  const NSString* kSearchHint = @"Type to search";
+  NSString* const kSearchHint = @"Type to search";
 
   // Wide width chooses the full string.
   [cell setSearchHintString:kSearchHint availableWidth:kWidth];
   EXPECT_TRUE([cell hintString]);
   EXPECT_TRUE([[[cell hintString] string] isEqualToString:kSearchHint]);
 
   // Narrow width suppresses entirely.
   [cell setSearchHintString:kSearchHint availableWidth:kNarrowWidth];
   EXPECT_FALSE([cell hintString]);
 }
 
 // Test that the cell drops all but the image if there is no room for
 // the entire keyword hint.
 TEST_F(AutocompleteTextFieldCellTest, TrimsKeywordHintIfNarrow) {
   AutocompleteTextFieldCell* cell =
       static_cast<AutocompleteTextFieldCell*>([view_ cell]);
   scoped_nsobject<NSImage> image(
       [[NSImage alloc] initWithSize:NSMakeSize(20, 20)]);
 
-  const NSString* kHintPrefix = @"Press ";
-  const NSString* kHintSuffix = @" to search Engine";
+  NSString* const kHintPrefix = @"Press ";
+  NSString* const kHintSuffix = @" to search Engine";
 
   // Wide width chooses the full string.
   [cell setKeywordHintPrefix:kHintPrefix image:image suffix:kHintSuffix
               availableWidth:kWidth];
   EXPECT_TRUE([cell hintString]);
   EXPECT_TRUE([[[cell hintString] string] hasPrefix:kHintPrefix]);
   EXPECT_TRUE([[[cell hintString] string] hasSuffix:kHintSuffix]);
 
   // Narrow width suppresses everything but the image.
   [cell setKeywordHintPrefix:kHintPrefix image:image suffix:kHintSuffix
               availableWidth:kNarrowWidth];
   EXPECT_EQ([[cell hintString] length], 1U);
 }
 
 }  // namespace