Mac/clang: First pass over unit_tests

chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/find_notification_details.h"
 #import "chrome/browser/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/cocoa/find_bar_cocoa_controller.h"
@@ skipping 11 matching lines @@
 
 @implementation FindBarCocoaController(Testing)
 - (NSView*)findBarView {
   return findBarView_;
 }
 
 - (NSString*)findText {
   return [findText_ stringValue];
 }
 
-- (NSTextField*)findTextField {
+- (FindBarTextField*)findTextField {
   return findText_;
 }
 @end
 
 namespace {
 
 class FindBarCocoaControllerTest : public CocoaTest {
  public:
   virtual void SetUp() {
     CocoaTest::SetUp();
@@ skipping 23 matching lines @@
 }
 
 TEST_F(FindBarCocoaControllerTest, SetFindText) {
   NSTextField* findTextField = [controller_ findTextField];
 
   // Start by making the find bar visible.
   [controller_ showFindBar:NO];
   EXPECT_TRUE([controller_ isFindBarVisible]);
 
   // Set the find text.
-  const NSString* kFindText = @"Google";
+  NSString* const kFindText = @"Google";
   [controller_ setFindText:kFindText];
   EXPECT_EQ(
       NSOrderedSame,
       [[findTextField stringValue] compare:kFindText]);
 
   // Call clearResults, which doesn't actually clear the find text but
   // simply sets it back to what it was before.  This is silly, but
   // matches the behavior on other platforms.  |details| isn't used by
   // our implementation of clearResults, so it's ok to pass in an
   // empty |details|.
   FindNotificationDetails details;
   [controller_ clearResults:details];
   EXPECT_EQ(
       NSOrderedSame,
       [[findTextField stringValue] compare:kFindText]);
 }
 
 TEST_F(FindBarCocoaControllerTest, ResultLabelUpdatesCorrectly) {
   // TODO(rohitrao): Test this.  It may involve creating some dummy
   // FindNotificationDetails objects.
 }
 
 TEST_F(FindBarCocoaControllerTest, FindTextIsGlobal) {
   scoped_nsobject<FindBarCocoaController> otherController(
       [[FindBarCocoaController alloc] init]);
   [[test_window() contentView] addSubview:[otherController view]];
 
   // Setting the text in one controller should update the other controller's
   // text as well.
-  const NSString* kFindText = @"Respect to the man in the ice cream van";
+  NSString* const kFindText = @"Respect to the man in the ice cream van";
   [controller_ setFindText:kFindText];
   EXPECT_EQ(
       NSOrderedSame,
       [[controller_ findText] compare:kFindText]);
   EXPECT_EQ(
       NSOrderedSame,
       [[otherController.get() findText] compare:kFindText]);
 }
 
 TEST_F(FindBarCocoaControllerTest, SettingFindTextUpdatesFindPboard) {
-  const NSString* kFindText =
+  NSString* const kFindText =
       @"It's not a bird, it's not a plane, it must be Dave who's on the train";
   [controller_ setFindText:kFindText];
   EXPECT_EQ(
       NSOrderedSame,
       [[[FindPasteboard sharedInstance] findText] compare:kFindText]);
 }
 
 }  // namespace