Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2096)

Unified Diff: chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm

Issue 2876002: Mac/clang: First pass over unit_tests (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
diff --git a/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm b/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
index 5bd02ccc41bfd59bc812f61b427644f65a415580..8f79424ce005756cbd3294cdf6e97e5ffa2ea5b8 100644
--- a/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
+++ b/chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm
@@ -435,8 +435,8 @@ TEST_F(AutocompleteTextFieldCellTest, UsesPartialKeywordIfNarrow) {
AutocompleteTextFieldCell* cell =
static_cast<AutocompleteTextFieldCell*>([view_ cell]);
- const NSString* kFullString = @"Search Engine:";
- const NSString* kPartialString = @"Search Eng:";
+ NSString* const kFullString = @"Search Engine:";
+ NSString* const kPartialString = @"Search Eng:";
// Wide width chooses the full string, including an image on the
// left.
@@ -477,7 +477,7 @@ TEST_F(AutocompleteTextFieldCellTest, OmitsSearchHintIfNarrow) {
AutocompleteTextFieldCell* cell =
static_cast<AutocompleteTextFieldCell*>([view_ cell]);
- const NSString* kSearchHint = @"Type to search";
+ NSString* const kSearchHint = @"Type to search";
// Wide width chooses the full string.
[cell setSearchHintString:kSearchHint availableWidth:kWidth];
@@ -497,8 +497,8 @@ TEST_F(AutocompleteTextFieldCellTest, TrimsKeywordHintIfNarrow) {
scoped_nsobject<NSImage> image(
[[NSImage alloc] initWithSize:NSMakeSize(20, 20)]);
- const NSString* kHintPrefix = @"Press ";
- const NSString* kHintSuffix = @" to search Engine";
+ NSString* const kHintPrefix = @"Press ";
+ NSString* const kHintSuffix = @" to search Engine";
// Wide width chooses the full string.
[cell setKeywordHintPrefix:kHintPrefix image:image suffix:kHintSuffix

Powered by Google App Engine
This is Rietveld 408576698