Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm

Issue 2876002: Mac/clang: First pass over unit_tests (Closed)
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
diff --git a/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm b/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
index c45c009f75c409ca6806ec8f462b8d8d8ec4ff4f..6532371f61e7819c14304a3306cd6e2fe743b546 100644
--- a/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
+++ b/chrome/browser/cocoa/find_bar_cocoa_controller_unittest.mm
@@ -29,7 +29,7 @@
return [findText_ stringValue];
}
-- (NSTextField*)findTextField {
+- (FindBarTextField*)findTextField {
return findText_;
}
@end
@@ -73,7 +73,7 @@ TEST_F(FindBarCocoaControllerTest, SetFindText) {
EXPECT_TRUE([controller_ isFindBarVisible]);
// Set the find text.
- const NSString* kFindText = @"Google";
+ NSString* const kFindText = @"Google";
[controller_ setFindText:kFindText];
EXPECT_EQ(
NSOrderedSame,
@@ -103,7 +103,7 @@ TEST_F(FindBarCocoaControllerTest, FindTextIsGlobal) {
// Setting the text in one controller should update the other controller's
// text as well.
- const NSString* kFindText = @"Respect to the man in the ice cream van";
+ NSString* const kFindText = @"Respect to the man in the ice cream van";
[controller_ setFindText:kFindText];
EXPECT_EQ(
NSOrderedSame,
@@ -114,7 +114,7 @@ TEST_F(FindBarCocoaControllerTest, FindTextIsGlobal) {
}
TEST_F(FindBarCocoaControllerTest, SettingFindTextUpdatesFindPboard) {
- const NSString* kFindText =
+ NSString* const kFindText =
@"It's not a bird, it's not a plane, it must be Dave who's on the train";
[controller_ setFindText:kFindText];
EXPECT_EQ(

Powered by Google App Engine
This is Rietveld 408576698