Mac/clang: First pass over unit_tests

chrome/browser/cocoa/autocomplete_text_field_unittest.mm

Index: chrome/browser/cocoa/autocomplete_text_field_unittest.mm
diff --git a/chrome/browser/cocoa/autocomplete_text_field_unittest.mm b/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
index 1f3ecd3fff07eb6fcd51de926b26979024adce08..1b418afa9f33719b46004b23e276340b33e70643 100644
--- a/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
+++ b/chrome/browser/cocoa/autocomplete_text_field_unittest.mm
@@ -356,7 +356,7 @@ TEST_F(AutocompleteTextFieldTest, ResetFieldEditorBase) {
 TEST_F(AutocompleteTextFieldTest, ResetFieldEditorSearchHint) {
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
 
-  const NSString* kHintString(@"Type to search");
+  NSString* const kHintString(@"Type to search");

[Mark Mentovai, 2010/06/23 13:51:28]

Use = instead of ().

 
   // Capture the editor frame resulting from the standard focus
   // machinery.
@@ -388,8 +388,8 @@ TEST_F(AutocompleteTextFieldTest, ResetFieldEditorSearchHint) {
 TEST_F(AutocompleteTextFieldTest, ResetFieldEditorKeywordHint) {
   AutocompleteTextFieldCell* cell = [field_ autocompleteTextFieldCell];
 
-  const NSString* kFullString(@"Search Engine:");
-  const NSString* kPartialString(@"Search Eng:");
+  NSString* const kFullString(@"Search Engine:");

[Mark Mentovai, 2010/06/23 13:51:28]

Ditto here and on the next line.

+  NSString* const kPartialString(@"Search Eng:");
 
   // Capture the editor frame resulting from the standard focus
   // machinery.
@@ -749,7 +749,7 @@ TEST_F(AutocompleteTextFieldTest, SetAttributedStringBaseline) {
   NSDictionary* attributes =
       [NSDictionary dictionaryWithObject:font
                                   forKey:NSFontAttributeName];
-  static const NSString* kString = @"This is a test";
+  NSString* const kString = @"This is a test";
   scoped_nsobject<NSAttributedString> attributedString(
       [[NSAttributedString alloc] initWithString:kString
                                       attributes:attributes]);
@@ -782,7 +782,7 @@ TEST_F(AutocompleteTextFieldTest, SetAttributedStringUndo) {
   NSDictionary* attributes =
       [NSDictionary dictionaryWithObject:redColor
                                   forKey:NSForegroundColorAttributeName];
-  static const NSString* kString = @"This is a test";
+  NSString* const kString = @"This is a test";
   scoped_nsobject<NSAttributedString> attributedString(
       [[NSAttributedString alloc] initWithString:kString
                                       attributes:attributes]);