Mac/clang: First pass over unit_tests

chrome/browser/autocomplete/autocomplete_popup_view_mac_unittest.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/autocomplete/autocomplete_popup_view_mac.h"
 
 #include "app/text_elider.h"
 #include "base/scoped_ptr.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
@@ skipping 82 matching lines @@
   }
 
   NSColor* color_;  // weak
   gfx::Font font_;
 };
 
 // Simple inputs with no matches should result in styled output who's
 // text matches the input string, with the passed-in color, and
 // nothing bolded.
 TEST_F(AutocompletePopupViewMacTest, DecorateMatchedStringNoMatch) {
-  const NSString* string = @"This is a test";
+  NSString* const string = @"This is a test";
   AutocompleteMatch::ACMatchClassifications classifications;
 
   NSAttributedString* decorated =
       AutocompletePopupViewMac::DecorateMatchedString(
           base::SysNSStringToWide(string), classifications,
           color_, font_);
 
   // Result has same characters as the input.
   EXPECT_EQ([decorated length], [string length]);
   EXPECT_TRUE([[decorated string] isEqualToString:string]);
 
   // Our passed-in color for the entire string.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSForegroundColorAttributeName),
             [string length]);
   EXPECT_TRUE(RunHasColor(decorated, 0U, color_));
 
   // An unbolded font for the entire string.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSFontAttributeName), [string length]);
   EXPECT_FALSE(RunHasFontTrait(decorated, 0U, NSBoldFontMask));
 }
 
 // Identical to DecorateMatchedStringNoMatch, except test that URL
 // style gets a different color than we passed in.
 TEST_F(AutocompletePopupViewMacTest, DecorateMatchedStringURLNoMatch) {
-  const NSString* string = @"This is a test";
+  NSString* const string = @"This is a test";
   AutocompleteMatch::ACMatchClassifications classifications;
 
   classifications.push_back(
       ACMatchClassification(0, ACMatchClassification::URL));
 
   NSAttributedString* decorated =
       AutocompletePopupViewMac::DecorateMatchedString(
           base::SysNSStringToWide(string), classifications,
           color_, font_);
 
   // Result has same characters as the input.
   EXPECT_EQ([decorated length], [string length]);
   EXPECT_TRUE([[decorated string] isEqualToString:string]);
 
   // One color for the entire string, and it's not the one we passed in.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSForegroundColorAttributeName),
             [string length]);
   EXPECT_FALSE(RunHasColor(decorated, 0U, color_));
 
   // An unbolded font for the entire string.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSFontAttributeName), [string length]);
   EXPECT_FALSE(RunHasFontTrait(decorated, 0U, NSBoldFontMask));
 }
 
 // Test that DIM doesn't have any impact - true at this time.
 TEST_F(AutocompletePopupViewMacTest, DecorateMatchedStringDimNoMatch) {
-  const NSString* string = @"This is a test";
+  NSString* const string = @"This is a test";
 
   // Switch to DIM halfway through.
   AutocompleteMatch::ACMatchClassifications classifications;
   classifications.push_back(
       ACMatchClassification(0, ACMatchClassification::NONE));
   classifications.push_back(
       ACMatchClassification([string length] / 2, ACMatchClassification::DIM));
 
   NSAttributedString* decorated =
       AutocompletePopupViewMac::DecorateMatchedString(
@@ skipping 12 matching lines @@
 
   // An unbolded font for the entire string.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSFontAttributeName), [string length]);
   EXPECT_FALSE(RunHasFontTrait(decorated, 0U, NSBoldFontMask));
 }
 
 // Test that the matched run gets bold-faced, but keeps the same
 // color.
 TEST_F(AutocompletePopupViewMacTest, DecorateMatchedStringMatch) {
-  const NSString* string = @"This is a test";
+  NSString* const string = @"This is a test";
   // Match "is".
   const NSUInteger runLength1 = 5, runLength2 = 2, runLength3 = 7;
   // Make sure nobody messed up the inputs.
   EXPECT_EQ(runLength1 + runLength2 + runLength3, [string length]);
 
   // Push each run onto classifications.
   AutocompleteMatch::ACMatchClassifications classifications;
   classifications.push_back(
       ACMatchClassification(0, ACMatchClassification::NONE));
   classifications.push_back(
@@ skipping 27 matching lines @@
   EXPECT_TRUE(RunHasFontTrait(decorated, runLength1, NSBoldFontMask));
 
   EXPECT_EQ(RunLengthForAttribute(decorated, runLength1 + runLength2,
                                   NSFontAttributeName), runLength3);
   EXPECT_FALSE(RunHasFontTrait(decorated, runLength1 + runLength2,
                                NSBoldFontMask));
 }
 
 // Just like DecorateMatchedStringURLMatch, this time with URL style.
 TEST_F(AutocompletePopupViewMacTest, DecorateMatchedStringURLMatch) {
-  const NSString* string = @"http://hello.world/";
+  NSString* const string = @"http://hello.world/";
   // Match "hello".
   const NSUInteger runLength1 = 7, runLength2 = 5, runLength3 = 7;
   // Make sure nobody messed up the inputs.
   EXPECT_EQ(runLength1 + runLength2 + runLength3, [string length]);
 
   // Push each run onto classifications.
   AutocompleteMatch::ACMatchClassifications classifications;
   classifications.push_back(
       ACMatchClassification(0, ACMatchClassification::URL));
   const int kURLMatch = ACMatchClassification::URL|ACMatchClassification::MATCH;
@@ skipping 30 matching lines @@
                                   NSFontAttributeName), runLength3);
   EXPECT_FALSE(RunHasFontTrait(decorated, runLength1 + runLength2,
                                NSBoldFontMask));
 }
 
 // Check that matches with both contents and description come back
 // with contents at the beginning, description at the end, and
 // something separating them.  Not being specific about the separator
 // on purpose, in case it changes.
 TEST_F(AutocompletePopupViewMacTest, MatchText) {
-  const NSString* contents = @"contents";
-  const NSString* description = @"description";
+  NSString* const contents = @"contents";
+  NSString* const description = @"description";
   AutocompleteMatch m = MakeMatch(base::SysNSStringToWide(contents),
                                   base::SysNSStringToWide(description));
 
   NSAttributedString* decorated =
       AutocompletePopupViewMac::MatchText(m, font_, kLargeWidth);
 
   // Result contains the characters of the input in the right places.
   EXPECT_GT([decorated length], [contents length] + [description length]);
   EXPECT_TRUE([[decorated string] hasPrefix:contents]);
   EXPECT_TRUE([[decorated string] hasSuffix:description]);
@@ skipping 10 matching lines @@
             [description length]);
 
   // Same font all the way through, nothing bold.
   EXPECT_EQ(RunLengthForAttribute(decorated, 0U,
                                   NSFontAttributeName), [decorated length]);
   EXPECT_FALSE(RunHasFontTrait(decorated, 0, NSBoldFontMask));
 }
 
 // Check that MatchText() styles content matches as expected.
 TEST_F(AutocompletePopupViewMacTest, MatchTextContentsMatch) {
-  const NSString* contents = @"This is a test";
+  NSString* const contents = @"This is a test";
   // Match "is".
   const NSUInteger runLength1 = 5, runLength2 = 2, runLength3 = 7;
   // Make sure nobody messed up the inputs.
   EXPECT_EQ(runLength1 + runLength2 + runLength3, [contents length]);
 
   AutocompleteMatch m = MakeMatch(base::SysNSStringToWide(contents),
                                   std::wstring());
 
   // Push each run onto contents classifications.
   m.contents_class.push_back(
@@ skipping 26 matching lines @@
   EXPECT_TRUE(RunHasFontTrait(decorated, runLength1, NSBoldFontMask));
 
   EXPECT_EQ(RunLengthForAttribute(decorated, runLength1 + runLength2,
                                   NSFontAttributeName), runLength3);
   EXPECT_FALSE(RunHasFontTrait(decorated, runLength1 + runLength2,
                                NSBoldFontMask));
 }
 
 // Check that MatchText() styles description matches as expected.
 TEST_F(AutocompletePopupViewMacTest, MatchTextDescriptionMatch) {
-  const NSString* contents = @"This is a test";
-  const NSString* description = @"That was a test";
+  NSString* const contents = @"This is a test";
+  NSString* const description = @"That was a test";
   // Match "That was".
   const NSUInteger runLength1 = 8, runLength2 = 7;
   // Make sure nobody messed up the inputs.
   EXPECT_EQ(runLength1 + runLength2, [description length]);
 
   AutocompleteMatch m = MakeMatch(base::SysNSStringToWide(contents),
                                   base::SysNSStringToWide(description));
 
   // Push each run onto contents classifications.
   m.description_class.push_back(
@@ skipping 31 matching lines @@
                                   NSFontAttributeName), runLength1);
   EXPECT_TRUE(RunHasFontTrait(decorated, descriptionLocation, NSBoldFontMask));
 
   EXPECT_EQ(RunLengthForAttribute(decorated, descriptionLocation + runLength1,
                                   NSFontAttributeName), runLength2);
   EXPECT_FALSE(RunHasFontTrait(decorated, descriptionLocation + runLength1,
                                NSBoldFontMask));
 }
 
 TEST_F(AutocompletePopupViewMacTest, ElideString) {
-  const NSString* contents = @"This is a test with long contents";
+  NSString* const contents = @"This is a test with long contents";
   const std::wstring wideContents(base::SysNSStringToWide(contents));
 
   const float kWide = 1000.0;
   const float kNarrow = 20.0;
 
   NSDictionary* attributes =
       [NSDictionary dictionaryWithObject:font_.nativeFont()
                                   forKey:NSFontAttributeName];
   scoped_nsobject<NSMutableAttributedString> as(
       [[NSMutableAttributedString alloc] initWithString:contents
@@ skipping 14 matching lines @@
 
   // When elided, result is the same as ElideText().
   ret = AutocompletePopupViewMac::ElideString(as, wideContents, font_, 0.0);
   elided = ElideText(wideContents, font_, 0.0, false);
   EXPECT_TRUE(ret == as);
   EXPECT_FALSE([[as string] isEqualToString:contents]);
   EXPECT_TRUE([[as string] isEqualToString:base::SysWideToNSString(elided)]);
 }
 
 TEST_F(AutocompletePopupViewMacTest, MatchTextElide) {
-  const NSString* contents = @"This is a test with long contents";
-  const NSString* description = @"That was a test";
+  NSString* const contents = @"This is a test with long contents";
+  NSString* const description = @"That was a test";
   // Match "long".
   const NSUInteger runLength1 = 20, runLength2 = 4, runLength3 = 9;
   // Make sure nobody messed up the inputs.
   EXPECT_EQ(runLength1 + runLength2 + runLength3, [contents length]);
 
   AutocompleteMatch m = MakeMatch(base::SysNSStringToWide(contents),
                                   base::SysNSStringToWide(description));
 
   // Push each run onto contents classifications.
   m.contents_class.push_back(
@@ skipping 53 matching lines @@
 // updates the model's selection from the matrix before returning.
 // Could possibly test that via -select:.
 
 // TODO(shess): Test that AutocompleteButtonCell returns the right
 // background colors for on, highlighted, and neither.
 
 // TODO(shess): Test that AutocompleteMatrixTarget can be initialized
 // and then sends -select: to the view.
 
 }  // namespace