Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h... (Closed)

Created:
11 years, 3 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Paul Godavari, jam, Paweł Hajdan Jr., darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Replace a bunch of hardcoded URLs with constants from url_constants.h TEST=none BUG=none

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -59 lines)			Patch
M	chrome/browser/autocomplete/keyword_provider_unittest.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_unittest.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/child_process_security_policy_unittest.cc	View	1	3 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/download/download_uitest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/save_page_browsertest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/about_chrome_dialog.cc	View	1	4 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/task_manager_gtk.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/view_id_util_browsertest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/history/url_database.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/login_prompt_uitest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/test/site_instance_unittest.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/toolbar_model.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/about_chrome_view.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/views/task_manager_view.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/url_constants.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_tests.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages