Replace a bunch of hardcoded URLs with constants from url_constants.h...

chrome/browser/views/about_chrome_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/about_chrome_view.h"
 
 #include <commdlg.h>
 
 #include "app/gfx/canvas.h"
 #include "app/gfx/color_utils.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/file_version_info.h"
 #include "base/string_util.h"
 #include "base/win_util.h"
 #include "base/word_iterator.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/metrics/user_metrics.h"
 #include "chrome/browser/views/restart_message_box.h"
 #include "chrome/common/chrome_constants.h"
+#include "chrome/common/url_constants.h"
 #include "chrome/installer/util/install_util.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "views/controls/textfield/textfield.h"
 #include "views/controls/throbber.h"
 #include "views/standard_layout.h"
 #include "views/widget/widget.h"
 #include "views/window/window.h"
 #include "webkit/glue/webkit_glue.h"
 
 namespace {
 // The pixel width of the version text field. Ideally, we'd like to have the
 // bounds set to the edge of the icon. However, the icon is not a view but a
 // part of the background, so we have to hard code the width to make sure
 // the version field doesn't overlap it.
 const int kVersionFieldWidth = 195;
 
-// The URLs that you navigate to when clicking the links in the About dialog.
-const wchar_t* const kAcknowledgements = L"about:credits";
-const wchar_t* const kTOS = L"about:terms";
-
 // These are used as placeholder text around the links in the text in the about
 // dialog.
 const wchar_t* kBeginLink = L"BEGIN_LINK";
 const wchar_t* kEndLink = L"END_LINK";
 const wchar_t* kBeginLinkChr = L"BEGIN_LINK_CHR";
 const wchar_t* kBeginLinkOss = L"BEGIN_LINK_OSS";
 const wchar_t* kEndLinkChr = L"END_LINK_CHR";
 const wchar_t* kEndLinkOss = L"END_LINK_OSS";
 
 // The background bitmap used to draw the background color for the About box
 // and the separator line (this is the image we will draw the logo on top of).
 static const SkBitmap* kBackgroundBmp = NULL;
 
 // Returns a substring from |text| between start and end.
 std::wstring StringSubRange(const std::wstring& text, size_t start,
                             size_t end) {
   DCHECK(end > start);
   return text.substr(start, end - start);
 }
 
 }  // namespace
 
 namespace browser {
 
-// Declared in browser_dialogs.h so that others don't need to depend on our .h. 
+// Declared in browser_dialogs.h so that others don't need to depend on our .h.
 void ShowAboutChromeView(views::Widget* parent,
                          Profile* profile) {
   views::Window::CreateChromeWindow(parent->GetNativeView(), gfx::Rect(),
                                     new AboutChromeView(profile))->Show();
 }
 
 }  // namespace browser
 
 ////////////////////////////////////////////////////////////////////////////////
 // AboutChromeView, public:
@@ skipping 613 matching lines @@
   return this;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AboutChromeView, views::LinkController implementation:
 
 void AboutChromeView::LinkActivated(views::Link* source,
                                     int event_flags) {
   GURL url;
   if (source == terms_of_service_url_)
-    url = GURL(kTOS);
+    url = GURL(chrome::kAboutTermsURL);
   else if (source == chromium_url_)
     url = GURL(l10n_util::GetString(IDS_CHROMIUM_PROJECT_URL));
   else if (source == open_source_url_)
-    url = GURL(kAcknowledgements);
+    url = GURL(chrome::kAboutCreditsURL);
   else
     NOTREACHED() << "Unknown link source";
 
   Browser* browser = BrowserList::GetLastActive();
   browser->OpenURL(url, GURL(), NEW_WINDOW, PageTransition::LINK);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AboutChromeView, GoogleUpdateStatusListener implementation:
 
@@ skipping 113 matching lines @@
 
   // We have updated controls on the parent, so we need to update its layout.
   View* parent = GetParent();
   parent->Layout();
 
   // Check button may have appeared/disappeared. We cannot call this during
   // ViewHierarchyChanged because the |window()| pointer hasn't been set yet.
   if (window())
     GetDialogClientView()->UpdateDialogButtons();
 }