Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: chrome/test/automated_ui_tests/automated_ui_tests.cc

Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | chrome/test/in_process_browser_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automated_ui_tests/automated_ui_tests.cc
===================================================================
--- chrome/test/automated_ui_tests/automated_ui_tests.cc (revision 26082)
+++ chrome/test/automated_ui_tests/automated_ui_tests.cc (working copy)
@@ -22,6 +22,7 @@
#include "chrome/common/chrome_paths.h"
#include "chrome/common/env_vars.h"
#include "chrome/common/libxml_utils.h"
+#include "chrome/common/url_constants.h"
#include "chrome/test/automated_ui_tests/automated_ui_tests.h"
#include "chrome/test/automation/browser_proxy.h"
#include "chrome/test/automation/tab_proxy.h"
@@ -346,7 +347,7 @@
} else if (LowerCaseEqualsASCII(action, "javascriptconsole")) {
did_complete_action = JavaScriptConsole();
} else if (LowerCaseEqualsASCII(action, "navigate")) {
- std::string url = "about:blank";
+ std::string url = chrome::kAboutBlankURL;
if (init_reader_.NodeAttribute("url", &url)) {
xml_writer_.AddAttribute("url", url);
}
@@ -624,7 +625,7 @@
bool AutomatedUITest::ForceCrash() {
scoped_refptr<TabProxy> tab(GetActiveTab());
- GURL test_url("about:crash");
+ GURL test_url(chrome::kAboutCrashURL);
bool did_timeout;
tab->NavigateToURLWithTimeout(test_url, 1, kDebuggingTimeoutMsec,
&did_timeout);
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | chrome/test/in_process_browser_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698