Replace a bunch of hardcoded URLs with constants from url_constants.h...

chrome/browser/gtk/about_chrome_dialog.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/about_chrome_dialog.h"
 
 #include <gtk/gtk.h>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/file_version_info.h"
 #include "base/gfx/gtk_util.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/gtk/gtk_chrome_link_button.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/gtk_util.h"
+#include "chrome/common/url_constants.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "webkit/glue/webkit_glue.h"
 
 namespace {
 
-// The URLs that you navigate to when clicking the links in the About dialog.
-const char* const kAcknowledgements = "about:credits";
-const char* const kTOS = "about:terms";
-
 // Left or right margin.
 const int kPanelHorizMargin = 13;
 
 // Top or bottom margin.
 const int kPanelVertMargin = 20;
 
 // Extra spacing between product name and version number.
 const int kExtraLineSpacing = 5;
 
 // These are used as placeholder text around the links in the text in the about
@@ skipping 158 matching lines @@
     GtkWidget* swap = second_link;
     second_link = first_link;
     first_link = swap;
   }
 
   g_signal_connect(chromium_url_appears_first ? first_link : second_link,
                    "clicked", G_CALLBACK(OnLinkButtonClick),
                    const_cast<char*>(GetChromiumUrl()));
   g_signal_connect(chromium_url_appears_first ? second_link : first_link,
                    "clicked", G_CALLBACK(OnLinkButtonClick),
-                   const_cast<char*>(kAcknowledgements));
+                   const_cast<char*>(chrome::kAboutCreditsURL));
 
   GtkWidget* license_hbox = gtk_hbox_new(FALSE, 0);
   gtk_box_pack_start(GTK_BOX(license_hbox), license_chunk1,
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(license_hbox), first_link,
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(license_hbox), license_chunk2,
                      FALSE, FALSE, 0);
 
   // Since there's no good way to dynamically wrap the license block, force
@@ skipping 25 matching lines @@
       gtk_chrome_link_button_new_with_markup(tos_link_text.c_str());
   GtkWidget* tos_chunk2 = MakeMarkupLabel(
       kSmaller, WideToUTF8(text.substr(url_offsets[0])).c_str());
 
   GtkWidget* tos_hbox = gtk_hbox_new(FALSE, 0);
   gtk_box_pack_start(GTK_BOX(tos_hbox), tos_chunk1, FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(tos_hbox), tos_link, FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(tos_hbox), tos_chunk2, FALSE, FALSE, 0);
 
   g_signal_connect(tos_link, "clicked", G_CALLBACK(OnLinkButtonClick),
-                   const_cast<char*>(kTOS));
+    const_cast<char*>(chrome::kAboutTermsURL));
   gtk_box_pack_start(GTK_BOX(vbox), tos_hbox, TRUE, TRUE, 0);
 #endif
 
   gtk_box_pack_start(GTK_BOX(content_area), vbox, TRUE, TRUE, 0);
 
   g_signal_connect(dialog, "response", G_CALLBACK(OnDialogResponse), NULL);
   gtk_window_set_resizable(GTK_WINDOW(dialog), FALSE);
   gtk_widget_show_all(dialog);
 }