Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/views/about_chrome_view.cc

Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/toolbar_model.cc ('k') | chrome/browser/views/task_manager_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/about_chrome_view.cc
===================================================================
--- chrome/browser/views/about_chrome_view.cc (revision 26082)
+++ chrome/browser/views/about_chrome_view.cc (working copy)
@@ -18,6 +18,7 @@
#include "chrome/browser/metrics/user_metrics.h"
#include "chrome/browser/views/restart_message_box.h"
#include "chrome/common/chrome_constants.h"
+#include "chrome/common/url_constants.h"
#include "chrome/installer/util/install_util.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
@@ -37,10 +38,6 @@
// the version field doesn't overlap it.
const int kVersionFieldWidth = 195;
-// The URLs that you navigate to when clicking the links in the About dialog.
-const wchar_t* const kAcknowledgements = L"about:credits";
-const wchar_t* const kTOS = L"about:terms";
-
// These are used as placeholder text around the links in the text in the about
// dialog.
const wchar_t* kBeginLink = L"BEGIN_LINK";
@@ -65,7 +62,7 @@
namespace browser {
-// Declared in browser_dialogs.h so that others don't need to depend on our .h.
+// Declared in browser_dialogs.h so that others don't need to depend on our .h.
void ShowAboutChromeView(views::Widget* parent,
Profile* profile) {
views::Window::CreateChromeWindow(parent->GetNativeView(), gfx::Rect(),
@@ -699,11 +696,11 @@
int event_flags) {
GURL url;
if (source == terms_of_service_url_)
- url = GURL(kTOS);
+ url = GURL(chrome::kAboutTermsURL);
else if (source == chromium_url_)
url = GURL(l10n_util::GetString(IDS_CHROMIUM_PROJECT_URL));
else if (source == open_source_url_)
- url = GURL(kAcknowledgements);
+ url = GURL(chrome::kAboutCreditsURL);
else
NOTREACHED() << "Unknown link source";
« no previous file with comments | « chrome/browser/toolbar_model.cc ('k') | chrome/browser/views/task_manager_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698