Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/browser_unittest.cc

Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/child_process_security_policy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_unittest.cc
===================================================================
--- chrome/browser/browser_unittest.cc (revision 26082)
+++ chrome/browser/browser_unittest.cc (working copy)
@@ -3,6 +3,7 @@
// LICENSE file.
#include "chrome/browser/browser.h"
+#include "chrome/common/url_constants.h"
#include "chrome/test/in_process_browser_test.h"
#include "net/base/mock_host_resolver.h"
@@ -36,7 +37,7 @@
EXPECT_EQ(1, popup_browser->tab_count());
// Now try opening another tab in the popup browser.
- popup_browser->AddTabWithURL(GURL("about:blank"), GURL(),
+ popup_browser->AddTabWithURL(GURL(chrome::kAboutBlankURL), GURL(),
PageTransition::TYPED, true, -1, NULL);
// The popup should still only have one tab.
@@ -52,7 +53,7 @@
EXPECT_EQ(1, app_browser->tab_count());
// Now try opening another tab in the app browser.
- app_browser->AddTabWithURL(GURL("about:blank"), GURL(),
+ app_browser->AddTabWithURL(GURL(chrome::kAboutBlankURL), GURL(),
PageTransition::TYPED, true, -1, NULL);
// The popup should still only have one tab.
@@ -68,7 +69,7 @@
EXPECT_EQ(1, app_popup_browser->tab_count());
// Now try opening another tab in the app popup browser.
- app_popup_browser->AddTabWithURL(GURL("about:blank"), GURL(),
+ app_popup_browser->AddTabWithURL(GURL(chrome::kAboutBlankURL), GURL(),
PageTransition::TYPED, true, -1, NULL);
// The popup should still only have one tab.
« no previous file with comments | « chrome/browser/browser.cc ('k') | chrome/browser/child_process_security_policy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698