Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/renderer/render_view.cc

Issue 193092: Replace a bunch of hardcoded URLs with constants from url_constants.h... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/render_view.cc
===================================================================
--- chrome/renderer/render_view.cc (revision 26082)
+++ chrome/renderer/render_view.cc (working copy)
@@ -1726,7 +1726,7 @@
// JavaScript.
bool is_fork =
// Must start from a tab showing about:blank, which is later redirected.
- GURL(frame->url()) == GURL("about:blank") &&
+ GURL(frame->url()) == GURL(chrome::kAboutBlankURL) &&
// Must be the first real navigation of the tab.
GetHistoryBackListCount() < 1 &&
GetHistoryForwardListCount() < 1 &&
@@ -2005,7 +2005,7 @@
// Notify the browser about non-blank documents loading in the top frame.
GURL url = frame->url();
- if (url.is_valid() && url.spec() != "about:blank") {
+ if (url.is_valid() && url.spec() != chrome::kAboutBlankURL) {
if (frame == webview()->GetMainFrame())
Send(new ViewHostMsg_DocumentAvailableInMainFrame(routing_id_));
}
« no previous file with comments | « chrome/common/url_constants.cc ('k') | chrome/test/automated_ui_tests/automated_ui_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698