RefCounted types should not have public destructors, chromeos edition

RefCounted types should not have public destructors, chromeos edition

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143987

[Ryan Sleevi, 2012-05-18 21:32:28]

Now that I have a ChromeOS+Clang+Warnings build, these are the fixes for CrOS.

This is just stamp collecting for CQ. None of these contain functional changes.

sky: ash/ , chrome/browser/ui (inc subdirs), ui/[aura, app_list],
content/browser
satorux: chrome/browser/chromeos/[extensions, gdata], webkit/chromeos
davemoore: chrome/browser/chromeos/* (everything else, but esp/ login)
mnissler: chrome/browser/policy

And since OWNERS is liberal, someone to take chrome/browser/extensions (I
nominate sky for stamping)

[satorux1, 2012-05-18 21:38:42]

chrome/browser/chromeos/extensions/ and chrome/browser/chromeos/gdata/ LGTM.

Could you wait until next week before submitting this? We are fixing the last
two M20 issues in chrome/browser/chromeos/gdata/ and /extensions/. We'd like to
minimize changes until m20 issues are gone.

[Ryan Sleevi, 2012-05-18 21:45:42]

On 2012/05/18 21:38:42, satorux1 wrote:
> chrome/browser/chromeos/extensions/ and chrome/browser/chromeos/gdata/ LGTM.
> 
> Could you wait until next week before submitting this? We are fixing the last
> two M20 issues in chrome/browser/chromeos/gdata/ and /extensions/. We'd like
to
> minimize changes until m20 issues are gone.

Sure. Now that http://crrev.com/137966 has landed, this is the last one
preventing the warning from being turned on across all platforms, but for now I
can turn it on for Mac & Linux only. When would be a good time to ping you for
an update?

[satorux1, 2012-05-18 21:47:51]

On 2012/05/18 21:45:42, Ryan Sleevi wrote:
> On 2012/05/18 21:38:42, satorux1 wrote:
> > chrome/browser/chromeos/extensions/ and chrome/browser/chromeos/gdata/ LGTM.
> > 
> > Could you wait until next week before submitting this? We are fixing the
last
> > two M20 issues in chrome/browser/chromeos/gdata/ and /extensions/. We'd like
> to
> > minimize changes until m20 issues are gone.
> 
> Sure. Now that http://crrev.com/137966 has landed, this is the last one
> preventing the warning from being turned on across all platforms, but for now
I
> can turn it on for Mac & Linux only. When would be a good time to ping you for
> an update?

I'll get back to you once the two m20 issues are gone. I expect to fix one by
the end of today...

[sky, 2012-05-18 22:18:30]

LGTM

[Mattias Nissler (ping if slow), 2012-05-21 08:34:05]

LGTM

[Nikita (slow), 2012-05-21 08:37:08]

chromeos/login lgtm

[satorux1, 2012-05-23 19:52:35]

Update. The last M20 issue in chrome/browser/chromeos/gdata/ and /extensions/ is
expected to be fixed this afternoon. Will get back to you once the fix is
landed.

[satorux1, 2012-05-24 06:07:47]

LGTM: the gdata patches are no in. It should be safe to submit this now.

http://src.chromium.org/viewvc/chrome?view=rev&revision=138686
http://src.chromium.org/viewvc/chrome?view=rev&revision=138730

[commit-bot: I haz the power, 2012-06-23 01:42:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/16001

[commit-bot: I haz the power, 2012-06-23 02:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/19002

[commit-bot: I haz the power, 2012-06-23 04:39:28]

Try job failure for 10386206-19002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-23 04:52:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/19002

[commit-bot: I haz the power, 2012-06-23 06:39:39]

Try job failure for 10386206-19002 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-23 18:49:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/19002

[commit-bot: I haz the power, 2012-06-23 22:07:21]

Try job failure for 10386206-19002 (retry) (retry) on win_rel for step
"browser_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-06-25 06:59:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/19002

[commit-bot: I haz the power, 2012-06-25 06:59:19]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_browser_private_api.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/chromeos/extensions/file_browser_private_api.cc
Hunk #1 FAILED at 550.
Hunk #2 succeeded at 690 (offset 120 lines).
Hunk #3 succeeded at 746 (offset 125 lines).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/file_browser_private_api.cc.rej

[commit-bot: I haz the power, 2012-06-25 17:46:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10386206/17043

[commit-bot: I haz the power, 2012-06-25 19:59:43]

Change committed as 143987