RefCounted types should not have public destructors, chromeos edition

chrome/browser/chromeos/mobile/mobile_activator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/mobile/mobile_activator.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 
@@ skipping 70 matching lines @@
 
 }  // namespace
 
 namespace chromeos {
 
 ////////////////////////////////////////////////////////////////////////////////
 //
 // CellularConfigDocument
 //
 ////////////////////////////////////////////////////////////////////////////////
-CellularConfigDocument::CellularConfigDocument() {
-}
-
-CellularConfigDocument::~CellularConfigDocument() {
-}
+CellularConfigDocument::CellularConfigDocument() {}
 
 std::string CellularConfigDocument::GetErrorMessage(const std::string& code) {
   base::AutoLock create(config_lock_);
   ErrorMap::iterator iter = error_map_.find(code);
   if (iter == error_map_.end())
     return code;
   return iter->second;
 }
 
 void CellularConfigDocument::LoadCellularConfigFile() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
   // Load partner customization startup manifest if it is available.
   FilePath config_path(kCellularConfigPath);
   if (!file_util::PathExists(config_path))
     return;
 
   if (LoadFromFile(config_path)) {
     DVLOG(1) << "Cellular config file loaded: " << kCellularConfigPath;
   } else {
     LOG(ERROR) << "Error loading cellular config file: " <<
         kCellularConfigPath;
   }
 }
 
+CellularConfigDocument::~CellularConfigDocument() {}
+
+void CellularConfigDocument::SetErrorMap(
+    const ErrorMap& map) {
+  base::AutoLock create(config_lock_);
+  error_map_.clear();
+  error_map_.insert(map.begin(), map.end());
+}
+
 bool CellularConfigDocument::LoadFromFile(const FilePath& config_path) {
   std::string config;
   if (!file_util::ReadFileToString(config_path, &config))
     return false;
 
   scoped_ptr<Value> root(
       base::JSONReader::Read(config, base::JSON_ALLOW_TRAILING_COMMAS));
   DCHECK(root.get() != NULL);
   if (!root.get() || root->GetType() != Value::TYPE_DICTIONARY) {
     LOG(WARNING) << "Bad cellular config file";
@@ skipping 16 matching lines @@
     if (!errors->GetString(*keys, &value)) {
       LOG(WARNING) << "Bad cellular config error value";
       return false;
     }
     error_map.insert(ErrorMap::value_type(*keys, value));
   }
   SetErrorMap(error_map);
   return true;
 }
 
-void CellularConfigDocument::SetErrorMap(
-    const ErrorMap& map) {
-  base::AutoLock create(config_lock_);
-  error_map_.clear();
-  error_map_.insert(map.begin(), map.end());
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 //
 // MobileActivator
 //
 ////////////////////////////////////////////////////////////////////////////////
 MobileActivator::MobileActivator()
     : cellular_config_(new CellularConfigDocument()),
       state_(PLAN_ACTIVATION_PAGE_LOADING),
       reenable_cert_check_(false),
       evaluating_(false),
@@ skipping 881 matching lines @@
     value->SetString("IMEI", device->imei());
     value->SetString("MDN", device->mdn());
   }
 }
 
 std::string MobileActivator::GetErrorMessage(const std::string& code) {
   return cellular_config_->GetErrorMessage(code);
 }
 
 }  // namespace chromeos