RefCounted types should not have public destructors, chromeos edition

chrome/browser/chromeos/gdata/gdata_protocol_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gdata/gdata_protocol_handler.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 109 matching lines @@
     system_service->docs_service()->operation_registry()->CancelForFilePath(
         gdata_file_path);
 }
 
 // GDataURLRequesetJob is the gateway between network-level drive://...
 // requests for gdata resources and GDataFileSytem.  It exposes content URLs
 // formatted as drive://<resource-id>.
 class GDataURLRequestJob : public net::URLRequestJob {
  public:
   explicit GDataURLRequestJob(net::URLRequest* request);
-  virtual ~GDataURLRequestJob();
 
   // net::URLRequestJob overrides:
   virtual void Start() OVERRIDE;
   virtual void Kill() OVERRIDE;
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
   virtual void GetResponseInfo(net::HttpResponseInfo* info) OVERRIDE;
   virtual int GetResponseCode() const OVERRIDE;
   virtual bool ReadRawData(net::IOBuffer* buf,
                            int buf_size,
                            int* bytes_read) OVERRIDE;
 
+ protected:
+  virtual ~GDataURLRequestJob();
+
  private:
   // Helper for Start() to let us start asynchronously.
   void StartAsync(GDataFileSystem** file_system);
 
   // Helper methods for Delegate::OnUrlFetchDownloadData and ReadRawData to
   // receive download data and copy to response buffer.
   // For detailed description of logic, refer to comments in definitions of
   // Start() and ReadRawData().
 
   void OnUrlFetchDownloadData(GDataErrorCode error,
@@ skipping 74 matching lines @@
       headers_set_(false),
       initial_file_size_(0),
       remaining_bytes_(0),
       streaming_download_(false),
       download_growable_buf_(new net::GrowableIOBuffer) {
   download_growable_buf_->SetCapacity(kInitialDownloadBufferSizeInBytes);
   download_drainable_buf_ = new net::DrainableIOBuffer(
       download_growable_buf_, download_growable_buf_->capacity());
 }
 
-GDataURLRequestJob::~GDataURLRequestJob() {
-  CloseFileStream();
-}
-
 void GDataURLRequestJob::Start() {
   DVLOG(1) << "Starting request";
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   // As per pattern shared by most net::URLRequestJob implementations, we start
   // asynchronously.
 
   // Here is how Start and its helper methods work:
   // 1) Post task to UI thread to get file system.
   //    Note: should we not post task to get file system later, start request
@@ skipping 204 matching lines @@
   DVLOG(1) << "ReadRawData: out with "
            << (rc ? "has" : "no")
            << "_data, bytes_read=" << *bytes_read
            << ", buf_remaining="
            << (read_buf_ ? read_buf_->BytesRemaining() : 0)
            << ", " << (streaming_download_ ? "download" : "file")
            << "_remaining=" << remaining_bytes_;
   return rc;
 }
 
+//======================= GDataURLRequestJob protected methods ================
+
+GDataURLRequestJob::~GDataURLRequestJob() {
+  CloseFileStream();
+}
+
 //======================= GDataURLRequestJob private methods ===================
 
 void GDataURLRequestJob::StartAsync(GDataFileSystem** file_system) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   file_system_ = *file_system;
 
   if (!request_ || !file_system_) {
     LOG(WARNING) << "Failed to start request: null "
                  << (!request_ ? "request" : "file system");
@@ skipping 446 matching lines @@
 GDataProtocolHandler::~GDataProtocolHandler() {
 }
 
 net::URLRequestJob* GDataProtocolHandler::MaybeCreateJob(
     net::URLRequest* request) const {
   DVLOG(1) << "Handling url: " << request->url().spec();
   return new GDataURLRequestJob(request);
 }
 
 }  // namespace gdata