RefCounted types should not have public destructors, chromeos edition

chrome/browser/chromeos/login/authenticator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_AUTHENTICATOR_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_AUTHENTICATOR_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/chromeos/login/login_status_consumer.h"
 #include "chrome/common/net/gaia/gaia_auth_consumer.h"
 
 class Profile;
 
 namespace chromeos {
 
 // An interface for objects that will authenticate a Chromium OS user.
 // When authentication successfully completes, will call
 // consumer_->OnLoginSuccess() on the UI thread.
 // On failure, will call consumer_->OnLoginFailure() on the UI thread.
 // On password change detected, will call
 // consumer_->OnPasswordChangeDetected() on the UI thread.
 class Authenticator : public base::RefCountedThreadSafe<Authenticator> {
  public:
   explicit Authenticator(LoginStatusConsumer* consumer);
-  virtual ~Authenticator();
 
   // Given externally authenticated |username| and |password|, this method
   // attempts to complete authentication process.
   virtual void CompleteLogin(Profile* profile,
                              const std::string& username,
                              const std::string& password) = 0;
 
   // Given a |username| and |password|, this method attempts to authenticate
   // to login.
   // Optionally |login_token| and |login_captcha| could be provided.
@@ skipping 46 matching lines @@
                          const std::string& username,
                          const std::string& password,
                          const std::string& login_token,
                          const std::string& login_captcha) = 0;
 
   // Profile (usually off the record ) that was used to perform the last
   // authentication process.
   Profile* authentication_profile() { return authentication_profile_; }
 
  protected:
+  virtual ~Authenticator();
+
   LoginStatusConsumer* consumer_;
   Profile* authentication_profile_;
 
  private:
+  friend class base::RefCountedThreadSafe<Authenticator>;
+
   DISALLOW_COPY_AND_ASSIGN(Authenticator);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_AUTHENTICATOR_H_