chrome/browser/chromeos/login/parallel_authenticator.h - Issue 10386206: RefCounted types should not have public destructors, chromeos edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase to r143931 Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/parallel_authenticator.h

diff --git a/chrome/browser/chromeos/login/parallel_authenticator.h b/chrome/browser/chromeos/login/parallel_authenticator.h

index 465fa238024c0c112aa85a5d18a90a889585a713..8410ef3d679a58fb00739aaceaecc7cc6b8fc494 100644

--- a/chrome/browser/chromeos/login/parallel_authenticator.h

+++ b/chrome/browser/chromeos/login/parallel_authenticator.h

@@ -67,7 +67,6 @@ class ParallelAuthenticator : public Authenticator,

};

explicit ParallelAuthenticator(LoginStatusConsumer* consumer);

- virtual ~ParallelAuthenticator();

// Authenticator overrides.

virtual void CompleteLogin(Profile* profile,

@@ -145,6 +144,9 @@ class ParallelAuthenticator : public Authenticator,

void OnOffTheRecordLoginSuccess();

void OnPasswordChangeDetected();

+ protected:

+ virtual ~ParallelAuthenticator();

private:

friend class ParallelAuthenticatorTest;

FRIEND_TEST_ALL_PREFIXES(ParallelAuthenticatorTest,