Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/app_pack_updater.cc ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_dialog.h
diff --git a/chrome/browser/ui/views/extensions/extension_dialog.h b/chrome/browser/ui/views/extensions/extension_dialog.h
index 272f27091a823a7e81f4eed390d58d88d5f99e77..3445eb5a3211e4ebf08f9cd0ce57f3567b3c6826 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog.h
+++ b/chrome/browser/ui/views/extensions/extension_dialog.h
@@ -29,8 +29,6 @@ class ExtensionDialog : public views::WidgetDelegate,
public content::NotificationObserver,
public base::RefCounted<ExtensionDialog> {
public:
- virtual ~ExtensionDialog();
-
// Create and show a dialog with |url| centered over the browser window.
// |browser| is the browser to which the pop-up will be attached.
// |web_contents| is the tab that spawned the dialog.
@@ -92,7 +90,12 @@ class ExtensionDialog : public views::WidgetDelegate,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
+ protected:
+ virtual ~ExtensionDialog();
+
private:
+ friend class base::RefCounted<ExtensionDialog>;
+
// Use Show() to create instances.
ExtensionDialog(ExtensionHost* host, ExtensionDialogObserver* observer);
« no previous file with comments | « chrome/browser/policy/app_pack_updater.cc ('k') | chrome/browser/ui/webui/about_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698