Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/browser/chromeos/extensions/file_handler_util.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_handler_util.h
diff --git a/chrome/browser/chromeos/extensions/file_handler_util.h b/chrome/browser/chromeos/extensions/file_handler_util.h
index 28614d0f54029bc494b075a981bb704a23bca0c5..e4f3c051ec6aac553c7e64d29bfbf1bc690cb255 100644
--- a/chrome/browser/chromeos/extensions/file_handler_util.h
+++ b/chrome/browser/chromeos/extensions/file_handler_util.h
@@ -82,7 +82,6 @@ class FileTaskExecutor : public base::RefCountedThreadSafe<FileTaskExecutor> {
const GURL source_url,
const std::string& extension_id,
const std::string& action_id);
- virtual ~FileTaskExecutor();
// Same as ExecuteAndNotify, but no notification is performed.
virtual bool Execute(const std::vector<GURL>& file_urls);
@@ -98,6 +97,7 @@ class FileTaskExecutor : public base::RefCountedThreadSafe<FileTaskExecutor> {
protected:
explicit FileTaskExecutor(Profile* profile);
+ virtual ~FileTaskExecutor();
// Returns the profile that this task was created with.
Profile* profile() { return profile_; }
@@ -105,6 +105,7 @@ class FileTaskExecutor : public base::RefCountedThreadSafe<FileTaskExecutor> {
// Returns a browser to use for the current browser.
Browser* GetBrowser() const;
private:
+ friend class base::RefCountedThreadSafe<FileTaskExecutor>;
Profile* profile_;
};

Powered by Google App Engine
This is Rietveld 408576698