Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 6965006: Update mips infrastructure files. (Closed)

Created:
9 years, 7 months ago by Paul Lind
Modified:
9 years, 7 months ago
CC:
v8-dev
Base URL:
http://github.com/v8/v8.git@bleeding_edge
Visibility:
Public.

Description

Update mips infrastructure files. - Merge to current tip of tree, fix build problems. - Remove deprecated source files. - Add cctest test-disasm-mips - Consistently use single-reg push()/pop() (remove uppercase variants) - Add assembler field accessors. - More style fixes. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7825

Patch Set 1 #

Patch Set 2 : Fix additional style issues. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1813 lines, -3979 lines) Patch
M src/mips/assembler-mips.h View 1 17 chunks +122 lines, -43 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 33 chunks +192 lines, -107 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 7 chunks +14 lines, -10 lines 2 comments Download
M src/mips/builtins-mips.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.h View 10 chunks +307 lines, -158 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 9 chunks +167 lines, -96 lines 0 comments Download
M src/mips/codegen-mips.h View 4 chunks +4 lines, -527 lines 0 comments Download
M src/mips/codegen-mips.cc View 3 chunks +2 lines, -1163 lines 0 comments Download
D src/mips/codegen-mips-inl.h View 1 chunk +0 lines, -64 lines 0 comments Download
M src/mips/constants-mips.h View 9 chunks +19 lines, -16 lines 0 comments Download
M src/mips/constants-mips.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M src/mips/cpu-mips.cc View 2 chunks +13 lines, -7 lines 0 comments Download
M src/mips/debug-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/disasm-mips.cc View 1 24 chunks +139 lines, -112 lines 0 comments Download
M src/mips/frames-mips.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/mips/frames-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M src/mips/ic-mips.cc View 1 3 chunks +2 lines, -35 lines 0 comments Download
D src/mips/jump-target-mips.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 4 chunks +8 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 29 chunks +154 lines, -56 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 56 chunks +391 lines, -117 lines 0 comments Download
M src/mips/regexp-macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/mips/register-allocator-mips.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/mips/register-allocator-mips.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D src/mips/register-allocator-mips-inl.h View 1 chunk +0 lines, -134 lines 0 comments Download
M src/mips/simulator-mips.h View 8 chunks +18 lines, -17 lines 0 comments Download
M src/mips/simulator-mips.cc View 65 chunks +162 lines, -143 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/mips/virtual-frame-mips.h View 1 chunk +0 lines, -530 lines 0 comments Download
D src/mips/virtual-frame-mips.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D src/mips/virtual-frame-mips-inl.h View 1 chunk +0 lines, -58 lines 0 comments Download
M test/cctest/SConscript View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +6 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 23 chunks +60 lines, -60 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
9 years, 7 months ago (2011-05-09 05:59:15 UTC) #1
Søren Thygesen Gjesse
LGTM I fixed the comments and committed. http://codereview.chromium.org/6965006/diff/1038/src/mips/assembler-mips-inl.h File src/mips/assembler-mips-inl.h (right): http://codereview.chromium.org/6965006/diff/1038/src/mips/assembler-mips-inl.h#newcode273 src/mips/assembler-mips-inl.h:273: } else ...
9 years, 7 months ago (2011-05-09 14:28:49 UTC) #2
Søren Thygesen Gjesse
9 years, 7 months ago (2011-05-09 14:30:46 UTC) #3
On 2011/05/09 14:28:49, Søren Gjesse wrote:
> LGTM
> 
> I fixed the comments and committed.
> 
> http://codereview.chromium.org/6965006/diff/1038/src/mips/assembler-mips-inl.h
> File src/mips/assembler-mips-inl.h (right):
> 
>
http://codereview.chromium.org/6965006/diff/1038/src/mips/assembler-mips-inl....
> src/mips/assembler-mips-inl.h:273: } else if (((RelocInfo::IsJSReturn(mode) &&
> One more space indent of IsPatchedReturnSequence().
> 
>
http://codereview.chromium.org/6965006/diff/1038/src/mips/assembler-mips-inl....
> src/mips/assembler-mips-inl.h:275: (RelocInfo::IsDebugBreakSlot(mode) &&
> And here.

Due to the commit just before, r7824, this does not compile dur to missing
function:

/usr/bin/ld: ./libv8.a(code-stubs.o): in function
v8::internal::ICCompareStub::Generate(v8::internal::MacroAssembler*):code-stubs.cc(.text._ZN2v88internal13ICCompareStub8GenerateEPNS0_14MacroAssemblerE+0x84):
error: undefined reference to
'v8::internal::ICCompareStub::GenerateSymbols(v8::internal::MacroAssembler*)'
collect2: ld returned 1 exit status

Powered by Google App Engine
This is Rietveld 408576698