|
Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures.
Likewise for EXPECT_DEATH_CHECK() and EXPECT_DEATH().
In the in-Chromium build configured for official builds in Release mode,
CHECK() throws away its condition string and stream parameters without
ever printing them, although it still evaluates the condition and
triggers death appropriately. {ASSERT,EXPECT}_DEATH(statement, regex)
will not work correctly for any regex that attempts to match what
CHECK() prints. In these build configurations,
{ASSERT,EXPECT}_DEATH_CHECK() use a match-all regex (""). In other build
configurations, they transparently wrap {ASSERT,EXPECT}_DEATH().
BUG= crashpad:12
R=rsesek@chromium.org, scottmg@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/26804a0be1f2a9d012cf1026130a3747fbcce409
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+127 lines, -40 lines) |
Patch |
|
M |
client/simple_string_dictionary_test.cc
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
minidump/minidump.gyp
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_exception_writer_test.cc
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_file_writer_test.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_module_writer_test.cc
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
minidump/minidump_system_info_writer_test.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_thread_writer_test.cc
|
View
|
|
2 chunks |
+4 lines, -2 lines |
0 comments
|
Download
|
|
M |
util/mach/composite_mach_message_server_test.cc
|
View
|
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
util/misc/initialization_state_dcheck_test.cc
|
View
|
|
8 chunks |
+19 lines, -14 lines |
0 comments
|
Download
|
|
M |
util/misc/scoped_forbid_return_test.cc
|
View
|
|
2 chunks |
+10 lines, -3 lines |
0 comments
|
Download
|
|
M |
util/net/http_multipart_builder_test.cc
|
View
|
|
2 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
A |
util/test/gtest_death_check.h
|
View
|
1
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
|
M |
util/test/multiprocess_posix_test.cc
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
|
M |
util/util.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|