Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: util/test/multiprocess_posix_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/test/gtest_death_check.h ('k') | util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/test/multiprocess_posix_test.cc
diff --git a/util/test/multiprocess_posix_test.cc b/util/test/multiprocess_posix_test.cc
index a8c7d9dafbab112fc1fc18dec1ab11170bb57c35..d0f133dafc86b27ba9ba23951772663916af6ad0 100644
--- a/util/test/multiprocess_posix_test.cc
+++ b/util/test/multiprocess_posix_test.cc
@@ -21,6 +21,7 @@
#include "base/basictypes.h"
#include "gtest/gtest.h"
#include "util/file/file_io.h"
+#include "util/test/gtest_death_check.h"
namespace crashpad {
namespace test {
@@ -189,7 +190,7 @@ class TestMultiprocessClosePipe final : public Multiprocess {
// abort execution. Regardless of how SIGPIPE is handled, the process will
// be terminated. Because the actual termination mechanism is not known,
// no regex can be specified.
- EXPECT_DEATH(CheckedWriteFile(WritePipeHandle(), &c, 1), "");
+ EXPECT_DEATH_CHECK(CheckedWriteFile(WritePipeHandle(), &c, 1), "");
}
}
@@ -198,18 +199,18 @@ class TestMultiprocessClosePipe final : public Multiprocess {
case kReadCloses:
CloseReadPipe();
EXPECT_NE(-1, WritePipeHandle());
- EXPECT_DEATH(ReadPipeHandle(), "fd");
+ EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
break;
case kWriteCloses:
CloseWritePipe();
EXPECT_NE(-1, ReadPipeHandle());
- EXPECT_DEATH(WritePipeHandle(), "fd");
+ EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
break;
case kReadAndWriteClose:
CloseReadPipe();
CloseWritePipe();
- EXPECT_DEATH(ReadPipeHandle(), "fd");
- EXPECT_DEATH(WritePipeHandle(), "fd");
+ EXPECT_DEATH_CHECK(ReadPipeHandle(), "fd");
+ EXPECT_DEATH_CHECK(WritePipeHandle(), "fd");
break;
}
}
« no previous file with comments | « util/test/gtest_death_check.h ('k') | util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698