Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: minidump/minidump_exception_writer_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump.gyp ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_exception_writer_test.cc
diff --git a/minidump/minidump_exception_writer_test.cc b/minidump/minidump_exception_writer_test.cc
index a0866ba0353b0014c29a4c956e9296379dc6ca3e..c8adeb43874e9934e9be889a9a5112b416e3dcff 100644
--- a/minidump/minidump_exception_writer_test.cc
+++ b/minidump/minidump_exception_writer_test.cc
@@ -34,6 +34,7 @@
#include "snapshot/test/test_cpu_context.h"
#include "snapshot/test/test_exception_snapshot.h"
#include "util/file/string_file.h"
+#include "util/test/gtest_death_check.h"
namespace crashpad {
namespace test {
@@ -262,15 +263,17 @@ TEST(MinidumpExceptionWriterDeathTest, NoContext) {
minidump_file_writer.AddStream(exception_writer.Pass());
StringFile string_file;
- ASSERT_DEATH(minidump_file_writer.WriteEverything(&string_file), "context_");
+ ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),
+ "context_");
}
TEST(MinidumpExceptionWriterDeathTest, TooMuchInformation) {
MinidumpExceptionWriter exception_writer;
std::vector<uint64_t> exception_information(EXCEPTION_MAXIMUM_PARAMETERS + 1,
0x5a5a5a5a5a5a5a5a);
- ASSERT_DEATH(exception_writer.SetExceptionInformation(exception_information),
- "kMaxParameters");
+ ASSERT_DEATH_CHECK(
+ exception_writer.SetExceptionInformation(exception_information),
+ "kMaxParameters");
}
} // namespace
« no previous file with comments | « minidump/minidump.gyp ('k') | minidump/minidump_file_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698