Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: client/simple_string_dictionary_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/simple_string_dictionary_test.cc
diff --git a/client/simple_string_dictionary_test.cc b/client/simple_string_dictionary_test.cc
index 173fee31d3223ec4493b9f8b5971b66590a07ac4..26a918bce0f371a59843e11ecb5b3dccedfc8788 100644
--- a/client/simple_string_dictionary_test.cc
+++ b/client/simple_string_dictionary_test.cc
@@ -16,6 +16,7 @@
#include "base/logging.h"
#include "gtest/gtest.h"
+#include "util/test/gtest_death_check.h"
namespace crashpad {
namespace test {
@@ -279,13 +280,13 @@ TEST(SimpleStringDictionary, OutOfSpace) {
TEST(SimpleStringDictionaryDeathTest, NullKey) {
TSimpleStringDictionary<4, 6, 6> map;
- ASSERT_DEATH(map.SetKeyValue(nullptr, "hello"), "key");
+ ASSERT_DEATH_CHECK(map.SetKeyValue(nullptr, "hello"), "key");
map.SetKeyValue("hi", "there");
- ASSERT_DEATH(map.GetValueForKey(nullptr), "key");
+ ASSERT_DEATH_CHECK(map.GetValueForKey(nullptr), "key");
EXPECT_STREQ("there", map.GetValueForKey("hi"));
- ASSERT_DEATH(map.GetValueForKey(nullptr), "key");
+ ASSERT_DEATH_CHECK(map.GetValueForKey(nullptr), "key");
map.RemoveKey("hi");
EXPECT_EQ(0u, map.GetCount());
}
« no previous file with comments | « no previous file | minidump/minidump.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698