Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: util/mach/composite_mach_message_server_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | util/misc/initialization_state_dcheck_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/mach/composite_mach_message_server.h" 15 #include "util/mach/composite_mach_message_server.h"
16 16
17 #include "base/strings/stringprintf.h" 17 #include "base/strings/stringprintf.h"
18 #include "gtest/gtest.h" 18 #include "gtest/gtest.h"
19 #include "util/mach/mach_message.h" 19 #include "util/mach/mach_message.h"
20 #include "util/test/gtest_death_check.h"
20 21
21 namespace crashpad { 22 namespace crashpad {
22 namespace test { 23 namespace test {
23 namespace { 24 namespace {
24 25
25 TEST(CompositeMachMessageServer, Empty) { 26 TEST(CompositeMachMessageServer, Empty) {
26 CompositeMachMessageServer server; 27 CompositeMachMessageServer server;
27 28
28 EXPECT_TRUE(server.MachMessageServerRequestIDs().empty()); 29 EXPECT_TRUE(server.MachMessageServerRequestIDs().empty());
29 30
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 TEST(CompositeMachMessageServerDeathTest, DuplicateRequestID) { 289 TEST(CompositeMachMessageServerDeathTest, DuplicateRequestID) {
289 const mach_msg_id_t kRequestID = 400; 290 const mach_msg_id_t kRequestID = 400;
290 291
291 TestMachMessageHandler handlers[2]; 292 TestMachMessageHandler handlers[2];
292 handlers[0].AddRequestID(kRequestID); 293 handlers[0].AddRequestID(kRequestID);
293 handlers[1].AddRequestID(kRequestID); 294 handlers[1].AddRequestID(kRequestID);
294 295
295 CompositeMachMessageServer server; 296 CompositeMachMessageServer server;
296 297
297 server.AddHandler(&handlers[0]); 298 server.AddHandler(&handlers[0]);
298 EXPECT_DEATH(server.AddHandler(&handlers[1]), "duplicate request ID"); 299 EXPECT_DEATH_CHECK(server.AddHandler(&handlers[1]), "duplicate request ID");
299 } 300 }
300 301
301 } // namespace 302 } // namespace
302 } // namespace test 303 } // namespace test
303 } // namespace crashpad 304 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | util/misc/initialization_state_dcheck_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698