Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: util/mach/composite_mach_message_server_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | util/misc/initialization_state_dcheck_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/composite_mach_message_server_test.cc
diff --git a/util/mach/composite_mach_message_server_test.cc b/util/mach/composite_mach_message_server_test.cc
index f1ec963ce0fccb1f21f3038b5757ca03080a1687..95f7d95222787ce645e8d0414027f17c8ac21ea6 100644
--- a/util/mach/composite_mach_message_server_test.cc
+++ b/util/mach/composite_mach_message_server_test.cc
@@ -17,6 +17,7 @@
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
#include "util/mach/mach_message.h"
+#include "util/test/gtest_death_check.h"
namespace crashpad {
namespace test {
@@ -295,7 +296,7 @@ TEST(CompositeMachMessageServerDeathTest, DuplicateRequestID) {
CompositeMachMessageServer server;
server.AddHandler(&handlers[0]);
- EXPECT_DEATH(server.AddHandler(&handlers[1]), "duplicate request ID");
+ EXPECT_DEATH_CHECK(server.AddHandler(&handlers[1]), "duplicate request ID");
}
} // namespace
« no previous file with comments | « minidump/minidump_thread_writer_test.cc ('k') | util/misc/initialization_state_dcheck_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698