Remove unnecessary add/removeObserver lifetime notifier indirections.

Remove unnecessary add/removeObserver lifetime notifier indirections.

With LifetimeNotifier<T,O>::{add,remove}Observer(O*) now being type
accurate & safe, we can simply expose these as public and avoid having
to define&declare forwarding versions. Unless the overriding is needed
(e.g., ContextLifecycleNotifier::addObserver().)

R=haraken
BUG=462949
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191537

[sof, 2015-03-09 09:39:40]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org

[sof, 2015-03-09 09:39:40]

please take a look.

[haraken, 2015-03-09 10:47:45]

LGTM

https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
File Source/core/dom/ContextLifecycleNotifier.cpp (right):

https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
Source/core/dom/ContextLifecycleNotifier.cpp:41: void
ContextLifecycleNotifier::addObserver(ContextLifecycleObserver* observer)

Do we still need this?

[sof, 2015-03-09 10:51:45]

https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
File Source/core/dom/ContextLifecycleNotifier.cpp (right):

https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
Source/core/dom/ContextLifecycleNotifier.cpp:41: void
ContextLifecycleNotifier::addObserver(ContextLifecycleObserver* observer)
On 2015/03/09 10:47:45, haraken wrote:
> 
> Do we still need this?

I'd argue that we still want that RELEASE_ASSERT() -- if a notification to stop
(or suspend) creates new ActiveDOMObjects and registers as observers, we'd miss
out on that. Something's that most likely wrong (indeed, this assert caught out
an Opera-internal bug just last week :) )

[haraken, 2015-03-09 10:55:49]

On 2015/03/09 10:51:45, sof wrote:
>
https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
> File Source/core/dom/ContextLifecycleNotifier.cpp (right):
> 
>
https://codereview.chromium.org/991763002/diff/1/Source/core/dom/ContextLifec...
> Source/core/dom/ContextLifecycleNotifier.cpp:41: void
> ContextLifecycleNotifier::addObserver(ContextLifecycleObserver* observer)
> On 2015/03/09 10:47:45, haraken wrote:
> > 
> > Do we still need this?
> 
> I'd argue that we still want that RELEASE_ASSERT() -- if a notification to
stop
> (or suspend) creates new ActiveDOMObjects and registers as observers, we'd
miss
> out on that. Something's that most likely wrong (indeed, this assert caught
out
> an Opera-internal bug just last week :) )

ok :)

[sof, 2015-03-09 11:43:49]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-03-09 11:44:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/991763002/1

[commit-bot: I haz the power, 2015-03-09 11:47:16]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191537