Source/core/page/PageLifecycleNotifier.h - Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageLifecycleNotifier.h

Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « Source/core/frame/DOMWindowLifecycleNotifier.cpp ('k') | Source/core/page/PageLifecycleNotifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/PageLifecycleNotifier.h

diff --git a/Source/core/page/PageLifecycleNotifier.h b/Source/core/page/PageLifecycleNotifier.h

index 4d97cf826c872512cb1a427bc11d8e21cd1e2ebc..58572883a829625cb4869cf742f88509506d0694 100644

--- a/Source/core/page/PageLifecycleNotifier.h

+++ b/Source/core/page/PageLifecycleNotifier.h

@@ -36,9 +36,6 @@ class PageLifecycleObserver;

class PageLifecycleNotifier : public LifecycleNotifier<Page, PageLifecycleObserver> {

public:

- void addObserver(PageLifecycleObserver*);

- void removeObserver(PageLifecycleObserver*);

void notifyPageVisibilityChanged();

void notifyDidCommitLoad(LocalFrame*);

« Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « Source/core/frame/DOMWindowLifecycleNotifier.cpp ('k') | Source/core/page/PageLifecycleNotifier.cpp » ('j') | no next file with comments »