Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: Source/core/page/PageLifecycleNotifier.h

Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "platform/LifecycleNotifier.h" 29 #include "platform/LifecycleNotifier.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 class LocalFrame; 33 class LocalFrame;
34 class Page; 34 class Page;
35 class PageLifecycleObserver; 35 class PageLifecycleObserver;
36 36
37 class PageLifecycleNotifier : public LifecycleNotifier<Page, PageLifecycleObserv er> { 37 class PageLifecycleNotifier : public LifecycleNotifier<Page, PageLifecycleObserv er> {
38 public: 38 public:
39 void addObserver(PageLifecycleObserver*);
40 void removeObserver(PageLifecycleObserver*);
41
42 void notifyPageVisibilityChanged(); 39 void notifyPageVisibilityChanged();
43 void notifyDidCommitLoad(LocalFrame*); 40 void notifyDidCommitLoad(LocalFrame*);
44 41
45 protected: 42 protected:
46 explicit PageLifecycleNotifier(Page*); 43 explicit PageLifecycleNotifier(Page*);
47 }; 44 };
48 45
49 } // namespace blink 46 } // namespace blink
50 47
51 #endif // PageLifecycleNotifier_h 48 #endif // PageLifecycleNotifier_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698