Source/core/frame/DOMWindowLifecycleNotifier.cpp - Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindowLifecycleNotifier.cpp

Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « Source/core/frame/DOMWindowLifecycleNotifier.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/DOMWindowLifecycleNotifier.cpp

diff --git a/Source/core/frame/DOMWindowLifecycleNotifier.cpp b/Source/core/frame/DOMWindowLifecycleNotifier.cpp

index 9ea2188f952b06b1e68d27c5381a16c404d1a14d..6352be27b770d5c2274e0aeb3056fc615bd1d9d3 100644

--- a/Source/core/frame/DOMWindowLifecycleNotifier.cpp

+++ b/Source/core/frame/DOMWindowLifecycleNotifier.cpp

@@ -36,16 +36,6 @@ DOMWindowLifecycleNotifier::DOMWindowLifecycleNotifier(LocalDOMWindow* context)

{

}

-void DOMWindowLifecycleNotifier::addObserver(DOMWindowLifecycleObserver* observer)

- LifecycleNotifier<LocalDOMWindow, DOMWindowLifecycleObserver>::addObserver(observer);

-void DOMWindowLifecycleNotifier::removeObserver(DOMWindowLifecycleObserver* observer)

- LifecycleNotifier<LocalDOMWindow, DOMWindowLifecycleObserver>::removeObserver(observer);

void DOMWindowLifecycleNotifier::notifyAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)

{

TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

« Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « Source/core/frame/DOMWindowLifecycleNotifier.h ('k') | Source/core/page/PageLifecycleNotifier.h » ('j') | no next file with comments »