Remove unnecessary add/removeObserver lifetime notifier indirections.

Source/core/dom/ContextLifecycleNotifier.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2013 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 20 matching lines @@
 #include "core/dom/ActiveDOMObject.h"
 #include "wtf/TemporaryChange.h"
 
 namespace blink {
 
 ContextLifecycleNotifier::ContextLifecycleNotifier(ExecutionContext* context)
     : LifecycleNotifier<ExecutionContext, ContextLifecycleObserver>(context)
 {
 }
 
 void ContextLifecycleNotifier::addObserver(ContextLifecycleObserver* observer)

[haraken, 2015/03/09 10:47:45]

Do we still need this?

[sof, 2015/03/09 10:51:44]

I'd argue that we still want that RELEASE_ASSERT() -- if a notification to stop
(or suspend) creates new ActiveDOMObjects and registers as observers, we'd miss
out on that. Something's that most likely wrong (indeed, this assert caught out
an Opera-internal bug just last week :) )

 {
     LifecycleNotifier<ExecutionContext, ContextLifecycleObserver>::addObserver(observer);
     if (observer->observerType() == ContextLifecycleObserver::ActiveDOMObjectType)
         RELEASE_ASSERT(m_iterating != IteratingOverActiveDOMObjects);
 }
 
-void ContextLifecycleNotifier::removeObserver(ContextLifecycleObserver* observer)
-{
-    LifecycleNotifier<ExecutionContext, ContextLifecycleObserver>::removeObserver(observer);
-}
-
 void ContextLifecycleNotifier::notifyResumingActiveDOMObjects()
 {
     TemporaryChange<IterationType> scope(m_iterating, IteratingOverActiveDOMObjects);
     Vector<ContextLifecycleObserver*> snapshotOfObservers;
     copyToVector(m_observers, snapshotOfObservers);
     for (ContextLifecycleObserver* observer : snapshotOfObservers) {
         // FIXME: Oilpan: At the moment, it's possible that a ActiveDOMObject
         // observer is destructed while iterating. Once we enable Oilpan by default
         // for all LifecycleObserver<T>s, we can remove the hack by making m_observers
         // a HeapHashSet<WeakMember<LifecycleObserver<T>>>.
@@ skipping 79 matching lines @@
             continue;
         ActiveDOMObject* activeDOMObject = static_cast<ActiveDOMObject*>(observer);
         if (activeDOMObject == object)
             return true;
     }
     return false;
 }
 #endif
 
 } // namespace blink