Source/core/frame/DOMWindowLifecycleNotifier.h - Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/DOMWindowLifecycleNotifier.h

Issue 991763002: Remove unnecessary add/removeObserver lifetime notifier indirections. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All Rights Reserved.	2 * Copyright (C) 2013 Google Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 18 matching lines...) Expand all Loading...
29 #include "platform/LifecycleNotifier.h"	29 #include "platform/LifecycleNotifier.h"

30 #include "wtf/Forward.h"	30 #include "wtf/Forward.h"

31	31

32 namespace blink {	32 namespace blink {

33	33

34 class DOMWindowLifecycleObserver;	34 class DOMWindowLifecycleObserver;

35 class LocalDOMWindow;	35 class LocalDOMWindow;

36	36

37 class DOMWindowLifecycleNotifier : public LifecycleNotifier<LocalDOMWindow, DOMW indowLifecycleObserver> {	37 class DOMWindowLifecycleNotifier : public LifecycleNotifier<LocalDOMWindow, DOMW indowLifecycleObserver> {

38 public:	38 public:

39 void addObserver(DOMWindowLifecycleObserver*);

40 void removeObserver(DOMWindowLifecycleObserver*);

41

42 void notifyAddEventListener(LocalDOMWindow*, const AtomicString& eventType);	39 void notifyAddEventListener(LocalDOMWindow*, const AtomicString& eventType);

43 void notifyRemoveEventListener(LocalDOMWindow*, const AtomicString& eventTyp e);	40 void notifyRemoveEventListener(LocalDOMWindow*, const AtomicString& eventTyp e);

44 void notifyRemoveAllEventListeners(LocalDOMWindow*);	41 void notifyRemoveAllEventListeners(LocalDOMWindow*);

45	42

46 protected:	43 protected:

47 explicit DOMWindowLifecycleNotifier(LocalDOMWindow*);	44 explicit DOMWindowLifecycleNotifier(LocalDOMWindow*);

48 };	45 };

49	46

50 } // namespace blink	47 } // namespace blink

51	48

52 #endif // DOMWindowLifecycleNotifier_h	49 #endif // DOMWindowLifecycleNotifier_h

OLD	NEW