Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch.

Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch.

When computing the code flags for a megamorphic store IC, we mistakenly
passed a strict_mode variable when an ExtraICState was expected.

R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18202

[mvstanton, 2013-12-02 14:10:54]

Hi Toon,
I noticed a missed line in the recent refactorings to use extra_ic_state.
ComputeFlags was accepting a StrictModeFlag in StoreIC::GenerateMegamorphic.
Thanks for the look,
--Michael

[Toon Verwaest, 2013-12-02 15:06:30]

https://codereview.chromium.org/98633005/diff/1/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

https://codereview.chromium.org/98633005/diff/1/src/arm/ic-arm.cc#newcode1506
src/arm/ic-arm.cc:1506: StrictModeFlag strict_mode) {
I'd make this be extra_ic_state rather than strict_mode, and pass in the right
value from the outside.

[mvstanton, 2013-12-02 15:14:58]

Good cmnt, thx! Uploaded a new patch.
--Michael

https://codereview.chromium.org/98633005/diff/1/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

https://codereview.chromium.org/98633005/diff/1/src/arm/ic-arm.cc#newcode1506
src/arm/ic-arm.cc:1506: StrictModeFlag strict_mode) {
On 2013/12/02 15:06:30, Toon Verwaest wrote:
> I'd make this be extra_ic_state rather than strict_mode, and pass in the right
> value from the outside.

Done.

[Toon Verwaest, 2013-12-02 15:29:29]

lgtm

[mvstanton, 2013-12-02 15:38:58]

Committed patchset #2 manually as r18202 (presubmit successful).