Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/arm/ic-arm.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1496 value, key, receiver, receiver_map, 1496 value, key, receiver, receiver_map,
1497 elements_map, elements); 1497 elements_map, elements);
1498 KeyedStoreGenerateGenericHelper(masm, &fast_object_grow, &fast_double_grow, 1498 KeyedStoreGenerateGenericHelper(masm, &fast_object_grow, &fast_double_grow,
1499 &slow, kDontCheckMap, kIncrementLength, 1499 &slow, kDontCheckMap, kIncrementLength,
1500 value, key, receiver, receiver_map, 1500 value, key, receiver, receiver_map,
1501 elements_map, elements); 1501 elements_map, elements);
1502 } 1502 }
1503 1503
1504 1504
1505 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1505 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1506 StrictModeFlag strict_mode) { 1506 ExtraICState extra_ic_state) {
1507 // ----------- S t a t e ------------- 1507 // ----------- S t a t e -------------
1508 // -- r0 : value 1508 // -- r0 : value
1509 // -- r1 : receiver 1509 // -- r1 : receiver
1510 // -- r2 : name 1510 // -- r2 : name
1511 // -- lr : return address 1511 // -- lr : return address
1512 // ----------------------------------- 1512 // -----------------------------------
1513 1513
1514 // Get the receiver from the stack and probe the stub cache. 1514 // Get the receiver from the stack and probe the stub cache.
1515 Code::Flags flags = Code::ComputeFlags( 1515 Code::Flags flags = Code::ComputeFlags(
1516 Code::HANDLER, MONOMORPHIC, strict_mode, 1516 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1517 Code::NORMAL, Code::STORE_IC); 1517 Code::NORMAL, Code::STORE_IC);
1518 1518
1519 masm->isolate()->stub_cache()->GenerateProbe( 1519 masm->isolate()->stub_cache()->GenerateProbe(
1520 masm, flags, r1, r2, r3, r4, r5, r6); 1520 masm, flags, r1, r2, r3, r4, r5, r6);
1521 1521
1522 // Cache miss: Jump to runtime. 1522 // Cache miss: Jump to runtime.
1523 GenerateMiss(masm); 1523 GenerateMiss(masm);
1524 } 1524 }
1525 1525
1526 1526
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1677 } else { 1677 } else {
1678 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1678 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1679 patcher.EmitCondition(eq); 1679 patcher.EmitCondition(eq);
1680 } 1680 }
1681 } 1681 }
1682 1682
1683 1683
1684 } } // namespace v8::internal 1684 } } // namespace v8::internal
1685 1685
1686 #endif // V8_TARGET_ARCH_ARM 1686 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698