Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/builtins.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1405 StoreIC::GenerateMiss(masm); 1405 StoreIC::GenerateMiss(masm);
1406 } 1406 }
1407 1407
1408 1408
1409 static void Generate_StoreIC_Normal(MacroAssembler* masm) { 1409 static void Generate_StoreIC_Normal(MacroAssembler* masm) {
1410 StoreIC::GenerateNormal(masm); 1410 StoreIC::GenerateNormal(masm);
1411 } 1411 }
1412 1412
1413 1413
1414 static void Generate_StoreIC_Megamorphic(MacroAssembler* masm) { 1414 static void Generate_StoreIC_Megamorphic(MacroAssembler* masm) {
1415 StoreIC::GenerateMegamorphic(masm, kNonStrictMode); 1415 StoreIC::GenerateMegamorphic(masm,
1416 StoreIC::ComputeExtraICState(kNonStrictMode));
1416 } 1417 }
1417 1418
1418 1419
1419 static void Generate_StoreIC_Megamorphic_Strict(MacroAssembler* masm) { 1420 static void Generate_StoreIC_Megamorphic_Strict(MacroAssembler* masm) {
1420 StoreIC::GenerateMegamorphic(masm, kStrictMode); 1421 StoreIC::GenerateMegamorphic(masm,
1422 StoreIC::ComputeExtraICState(kStrictMode));
1421 } 1423 }
1422 1424
1423 1425
1424 static void Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) { 1426 static void Generate_StoreIC_Setter_ForDeopt(MacroAssembler* masm) {
1425 StoreStubCompiler::GenerateStoreViaSetter(masm, Handle<JSFunction>()); 1427 StoreStubCompiler::GenerateStoreViaSetter(masm, Handle<JSFunction>());
1426 } 1428 }
1427 1429
1428 1430
1429 static void Generate_StoreIC_Generic(MacroAssembler* masm) { 1431 static void Generate_StoreIC_Generic(MacroAssembler* masm) {
1430 StoreIC::GenerateRuntimeSetProperty(masm, kNonStrictMode); 1432 StoreIC::GenerateRuntimeSetProperty(masm, kNonStrictMode);
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
1785 } 1787 }
1786 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 1788 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
1787 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 1789 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
1788 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 1790 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
1789 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 1791 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
1790 #undef DEFINE_BUILTIN_ACCESSOR_C 1792 #undef DEFINE_BUILTIN_ACCESSOR_C
1791 #undef DEFINE_BUILTIN_ACCESSOR_A 1793 #undef DEFINE_BUILTIN_ACCESSOR_A
1792 1794
1793 1795
1794 } } // namespace v8::internal 1796 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698