src/arm/ic-arm.cc - Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/ic-arm.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Verbal comment responses. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/ic-arm.cc

diff --git a/src/arm/ic-arm.cc b/src/arm/ic-arm.cc

index dd3840aab20fd25289d79e082262a1bd27404ac3..ea247b376397947b1a0f4e939678f1cf0ffe68c1 100644

--- a/src/arm/ic-arm.cc

+++ b/src/arm/ic-arm.cc

@@ -1503,7 +1503,7 @@ void KeyedStoreIC::GenerateGeneric(MacroAssembler* masm,

void StoreIC::GenerateMegamorphic(MacroAssembler* masm,

- StrictModeFlag strict_mode) {

+ ExtraICState extra_ic_state) {

// ----------- S t a t e -------------

// -- r0 : value

// -- r1 : receiver

@@ -1513,7 +1513,7 @@ void StoreIC::GenerateMegamorphic(MacroAssembler* masm,

// Get the receiver from the stack and probe the stub cache.

Code::Flags flags = Code::ComputeFlags(

- Code::HANDLER, MONOMORPHIC, strict_mode,

+ Code::HANDLER, MONOMORPHIC, extra_ic_state,

Code::NORMAL, Code::STORE_IC);

masm->isolate()->stub_cache()->GenerateProbe(

« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »