Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: src/x64/ic-x64.cc

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/ic-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1445 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 __ push(rdx); // receiver 1456 __ push(rdx); // receiver
1457 __ push(rax); // name 1457 __ push(rax); // name
1458 __ PushReturnAddressFrom(rbx); 1458 __ PushReturnAddressFrom(rbx);
1459 1459
1460 // Perform tail call to the entry. 1460 // Perform tail call to the entry.
1461 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1); 1461 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1);
1462 } 1462 }
1463 1463
1464 1464
1465 void StoreIC::GenerateMegamorphic(MacroAssembler* masm, 1465 void StoreIC::GenerateMegamorphic(MacroAssembler* masm,
1466 StrictModeFlag strict_mode) { 1466 ExtraICState extra_ic_state) {
1467 // ----------- S t a t e ------------- 1467 // ----------- S t a t e -------------
1468 // -- rax : value 1468 // -- rax : value
1469 // -- rcx : name 1469 // -- rcx : name
1470 // -- rdx : receiver 1470 // -- rdx : receiver
1471 // -- rsp[0] : return address 1471 // -- rsp[0] : return address
1472 // ----------------------------------- 1472 // -----------------------------------
1473 1473
1474 // Get the receiver from the stack and probe the stub cache. 1474 // Get the receiver from the stack and probe the stub cache.
1475 Code::Flags flags = Code::ComputeFlags( 1475 Code::Flags flags = Code::ComputeFlags(
1476 Code::HANDLER, MONOMORPHIC, strict_mode, 1476 Code::HANDLER, MONOMORPHIC, extra_ic_state,
1477 Code::NORMAL, Code::STORE_IC); 1477 Code::NORMAL, Code::STORE_IC);
1478 masm->isolate()->stub_cache()->GenerateProbe( 1478 masm->isolate()->stub_cache()->GenerateProbe(
1479 masm, flags, rdx, rcx, rbx, no_reg); 1479 masm, flags, rdx, rcx, rbx, no_reg);
1480 1480
1481 // Cache miss: Jump to runtime. 1481 // Cache miss: Jump to runtime.
1482 GenerateMiss(masm); 1482 GenerateMiss(masm);
1483 } 1483 }
1484 1484
1485 1485
1486 void StoreIC::GenerateMiss(MacroAssembler* masm) { 1486 void StoreIC::GenerateMiss(MacroAssembler* masm) {
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1698 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1699 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1699 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1700 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1700 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1701 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1701 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1702 } 1702 }
1703 1703
1704 1704
1705 } } // namespace v8::internal 1705 } } // namespace v8::internal
1706 1706
1707 #endif // V8_TARGET_ARCH_X64 1707 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/ic-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698