Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/ic.h

Issue 98633005: Bug in StoreIC::GenerateMegamorphic: strict_mode/extra_ic_state mismatch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Verbal comment responses. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/mips/ic-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 StrictModeFlag strict_mode() const { return strict_mode_; } 588 StrictModeFlag strict_mode() const { return strict_mode_; }
589 589
590 // Code generators for stub routines. Only called once at startup. 590 // Code generators for stub routines. Only called once at startup.
591 static void GenerateSlow(MacroAssembler* masm); 591 static void GenerateSlow(MacroAssembler* masm);
592 static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); } 592 static void GenerateInitialize(MacroAssembler* masm) { GenerateMiss(masm); }
593 static void GeneratePreMonomorphic(MacroAssembler* masm) { 593 static void GeneratePreMonomorphic(MacroAssembler* masm) {
594 GenerateMiss(masm); 594 GenerateMiss(masm);
595 } 595 }
596 static void GenerateMiss(MacroAssembler* masm); 596 static void GenerateMiss(MacroAssembler* masm);
597 static void GenerateMegamorphic(MacroAssembler* masm, 597 static void GenerateMegamorphic(MacroAssembler* masm,
598 StrictModeFlag strict_mode); 598 ExtraICState extra_ic_state);
599 static void GenerateNormal(MacroAssembler* masm); 599 static void GenerateNormal(MacroAssembler* masm);
600 static void GenerateRuntimeSetProperty(MacroAssembler* masm, 600 static void GenerateRuntimeSetProperty(MacroAssembler* masm,
601 StrictModeFlag strict_mode); 601 StrictModeFlag strict_mode);
602 602
603 MUST_USE_RESULT MaybeObject* Store( 603 MUST_USE_RESULT MaybeObject* Store(
604 Handle<Object> object, 604 Handle<Object> object,
605 Handle<String> name, 605 Handle<String> name,
606 Handle<Object> value, 606 Handle<Object> value,
607 JSReceiver::StoreFromKeyed store_mode = 607 JSReceiver::StoreFromKeyed store_mode =
608 JSReceiver::CERTAINLY_NOT_STORE_FROM_KEYED); 608 JSReceiver::CERTAINLY_NOT_STORE_FROM_KEYED);
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
939 DECLARE_RUNTIME_FUNCTION(MaybeObject*, KeyedCallIC_MissFromStubFailure); 939 DECLARE_RUNTIME_FUNCTION(MaybeObject*, KeyedCallIC_MissFromStubFailure);
940 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss); 940 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ElementsTransitionAndStoreIC_Miss);
941 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss); 941 DECLARE_RUNTIME_FUNCTION(MaybeObject*, BinaryOpIC_Miss);
942 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss); 942 DECLARE_RUNTIME_FUNCTION(MaybeObject*, CompareNilIC_Miss);
943 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss); 943 DECLARE_RUNTIME_FUNCTION(MaybeObject*, ToBooleanIC_Miss);
944 944
945 945
946 } } // namespace v8::internal 946 } } // namespace v8::internal
947 947
948 #endif // V8_IC_H_ 948 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/mips/ic-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698