[Password Manager Cleanup] Replaces NULL -> nullptr.

[Password Manager Cleanup] Replaces NULL -> nullptr.

Usage:
find "components/password_manager" -name '*.cc' | xargs sed -i 's/NULL/nullptr/g'
find "chrome/browser/password_manager" -name '*.cc' | xargs sed -i 's/NULL/nullptr/g'

BUG=461285
Committed: https://crrev.com/3ac2b57922ce197455f069b6190ea4e768d12e74
Cr-Commit-Position: refs/heads/master@{#317798}

[Pritam Nikam, 2015-02-24 10:56:18]

pritam.nikam@samsung.com changed reviewers:
+ vabr@chromium.org

[Pritam Nikam, 2015-02-24 10:56:19]

Hi Vaclav,

I could see NULL being used in many places in password_form_manager_unittest.cc
& other password_manager files. And thats the motivation behind this cleanup CL,
PTAL.

Thanks!

[vabr (Chromium), 2015-02-24 11:40:14]

Hi Pritam,

Please create a bug for this (see http://crbug.com/430733 for inspiration).

Once you address my comments below, this LGTM.

Thanks,
Vaclav

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/native_backend_gnome_x.cc:178: for (GList*
element = g_list_first(found); element != nullptr;
nit: you could even drop "!= nullptr".

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
(right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc:593:
EXPECT_FALSE(response.get() == nullptr);
EXPECT_TRUE(response);

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_store_x.cc (right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_store_x.cc:242:
backend_.reset(nullptr);
Just call reset() instead of reset(nullptr).
Also on other places.

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:60: // May be
nullptr in tests.
In plain English, prefer the English noun "null" to the C++ term "nullptr":
// May be null in tests.

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:459:
ASSERT_FALSE(nullptr == form_to_save.get());
ASSERT_TRUE(form_to_save);

[Pritam Nikam, 2015-02-24 12:28:51]

Thanks Vaclav!
PTAL @ new patch set, thanks!

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/native_backend_gnome_x.cc (right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/native_backend_gnome_x.cc:178: for (GList*
element = g_list_first(found); element != nullptr;
On 2015/02/24 11:40:14, vabr (Chromium) wrote:
> nit: you could even drop "!= nullptr".

Done.

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
(right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc:593:
EXPECT_FALSE(response.get() == nullptr);
On 2015/02/24 11:40:14, vabr (Chromium) wrote:
> EXPECT_TRUE(response);

Done.

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_store_x.cc (right):

https://codereview.chromium.org/951883002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_store_x.cc:242:
backend_.reset(nullptr);
On 2015/02/24 11:40:14, vabr (Chromium) wrote:
> Just call reset() instead of reset(nullptr).
> Also on other places.

Done.

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager.cc (right):

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager.cc:60: // May be
nullptr in tests.
On 2015/02/24 11:40:14, vabr (Chromium) wrote:
> In plain English, prefer the English noun "null" to the C++ term "nullptr":
> // May be null in tests.

Done.

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
File components/password_manager/core/browser/password_manager_unittest.cc
(right):

https://codereview.chromium.org/951883002/diff/1/components/password_manager/...
components/password_manager/core/browser/password_manager_unittest.cc:459:
ASSERT_FALSE(nullptr == form_to_save.get());
On 2015/02/24 11:40:14, vabr (Chromium) wrote:
> ASSERT_TRUE(form_to_save);

Done.

[vabr (Chromium), 2015-02-24 14:13:56]

LGTM, Thanks for the clean-up!
Vaclav

[Pritam Nikam, 2015-02-24 14:14:37]

The CQ bit was checked by pritam.nikam@samsung.com

[commit-bot: I haz the power, 2015-02-24 14:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/951883002/20001

[commit-bot: I haz the power, 2015-02-24 15:16:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-24 15:17:24]

Patchset 2 (id:??) landed as
https://crrev.com/3ac2b57922ce197455f069b6190ea4e768d12e74
Cr-Commit-Position: refs/heads/master@{#317798}