components/password_manager/core/browser/password_syncable_service.cc - Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Vaclav's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.cc

diff --git a/components/password_manager/core/browser/password_syncable_service.cc b/components/password_manager/core/browser/password_syncable_service.cc

index 5e07e7e35fbbbdfc8fa3713c0e94ef8b3ac1f5b6..b036b50605ed882a757f1d4f770b66656d3681b0 100644

--- a/components/password_manager/core/browser/password_syncable_service.cc

+++ b/components/password_manager/core/browser/password_syncable_service.cc

@@ -113,10 +113,10 @@ struct PasswordSyncableService::SyncEntries {

case syncer::SyncChange::ACTION_DELETE:

return &deleted_entries;

case syncer::SyncChange::ACTION_INVALID:

- return NULL;

+ return nullptr;

}

NOTREACHED();

- return NULL;

+ return nullptr;

}

// List that contains the entries that are known only to sync.

@@ -230,7 +230,7 @@ syncer::SyncDataList PasswordSyncableService::GetAllSyncData(

DCHECK(CalledOnValidThread());

DCHECK_EQ(syncer::PASSWORDS, type);

ScopedVector<autofill::PasswordForm> password_entries;

- ReadFromPasswordStore(&password_entries, NULL);

+ ReadFromPasswordStore(&password_entries, nullptr);

syncer::SyncDataList sync_data;

for (PasswordForms::iterator it = password_entries.begin();