Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vaclav's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_form_manager.h" 5 #include "components/password_manager/core/browser/password_form_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 PasswordManager* password_manager, 88 PasswordManager* password_manager,
89 PasswordManagerClient* client, 89 PasswordManagerClient* client,
90 const base::WeakPtr<PasswordManagerDriver>& driver, 90 const base::WeakPtr<PasswordManagerDriver>& driver,
91 const PasswordForm& observed_form, 91 const PasswordForm& observed_form,
92 bool ssl_valid) 92 bool ssl_valid)
93 : best_matches_deleter_(&best_matches_), 93 : best_matches_deleter_(&best_matches_),
94 observed_form_(CopyAndModifySSLValidity(observed_form, ssl_valid)), 94 observed_form_(CopyAndModifySSLValidity(observed_form, ssl_valid)),
95 is_new_login_(true), 95 is_new_login_(true),
96 has_generated_password_(false), 96 has_generated_password_(false),
97 password_manager_(password_manager), 97 password_manager_(password_manager),
98 preferred_match_(NULL), 98 preferred_match_(nullptr),
99 state_(PRE_MATCHING_PHASE), 99 state_(PRE_MATCHING_PHASE),
100 client_(client), 100 client_(client),
101 manager_action_(kManagerActionNone), 101 manager_action_(kManagerActionNone),
102 user_action_(kUserActionNone), 102 user_action_(kUserActionNone),
103 submit_result_(kSubmitResultNotSubmitted) { 103 submit_result_(kSubmitResultNotSubmitted) {
104 drivers_.push_back(driver); 104 drivers_.push_back(driver);
105 if (observed_form_.origin.is_valid()) 105 if (observed_form_.origin.is_valid())
106 base::SplitString(observed_form_.origin.path(), '/', &form_path_tokens_); 106 base::SplitString(observed_form_.origin.path(), '/', &form_path_tokens_);
107 } 107 }
108 108
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMITTED); 888 LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMITTED);
889 } 889 }
890 890
891 void PasswordFormManager::SubmitFailed() { 891 void PasswordFormManager::SubmitFailed() {
892 submit_result_ = kSubmitResultFailed; 892 submit_result_ = kSubmitResultFailed;
893 if (has_generated_password_) 893 if (has_generated_password_)
894 LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMISSION_FAILED); 894 LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMISSION_FAILED);
895 } 895 }
896 896
897 } // namespace password_manager 897 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698