Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vaclav's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index 36ef7afa0e1f3f1045ce60b346e12d30d8f8edb6..1ec170b7f73c8f55389143332a65ab96e5058cdd 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -111,7 +111,7 @@ class PasswordManagerTest : public testing::Test {
manager_.reset(new TestPasswordManager(&client_));
password_autofill_manager_.reset(
- new PasswordAutofillManager(client_.GetDriver(), NULL));
+ new PasswordAutofillManager(client_.GetDriver(), nullptr));
EXPECT_CALL(driver_, GetPasswordManager())
.WillRepeatedly(Return(manager_.get()));
@@ -126,7 +126,7 @@ class PasswordManagerTest : public testing::Test {
void TearDown() override {
store_->Shutdown();
- store_ = NULL;
+ store_ = nullptr;
}
PasswordForm MakeSimpleForm() {
@@ -456,7 +456,7 @@ TEST_F(PasswordManagerTest, FormSubmitAfterNavigateInPage) {
manager()->OnPasswordFormsRendered(&driver_, observed,
true); // The post-navigation layout.
- ASSERT_FALSE(NULL == form_to_save.get());
+ ASSERT_TRUE(form_to_save);
EXPECT_CALL(*store_, AddLogin(FormMatches(form)));
// Simulate saving the form, as if the info bar was accepted.

Powered by Google App Engine
This is Rietveld 408576698