Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6880)

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Vaclav's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
index 1239e8dcf4816ab4cb96fd82c6d5a5e3bf698307..4105ed75f5bcd61fd898765199714f0fe2fa4d73 100644
--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
@@ -477,7 +477,7 @@ dbus::Response* NativeBackendKWalletTest::KLauncherMethodCall(
dbus::Response* NativeBackendKWalletTest::KWalletMethodCall(
dbus::MethodCall* method_call, testing::Unused) {
if (!kwallet_running_)
- return NULL;
+ return nullptr;
EXPECT_EQ("org.kde.KWallet", method_call->GetInterface());
if (ContainsKey(failing_methods_, method_call->GetMember()))
@@ -574,7 +574,7 @@ dbus::Response* NativeBackendKWalletTest::KWalletMethodCall(
int handle = NativeBackendKWalletStub::kInvalidKWalletHandle;
std::string folder_name;
std::string key;
- const uint8_t* bytes = NULL;
+ const uint8_t* bytes = nullptr;
size_t length = 0;
std::string app_name;
EXPECT_TRUE(reader.PopInt32(&handle));
@@ -590,7 +590,7 @@ dbus::Response* NativeBackendKWalletTest::KWalletMethodCall(
TestKWallet::Blob(bytes, length)) ? 0 : 1);
}
- EXPECT_FALSE(response.get() == NULL);
+ EXPECT_TRUE(response);
return response.release();
}

Powered by Google App Engine
This is Rietveld 408576698