components/password_manager/core/browser/password_manager.cc - Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 951883002: [Password Manager Cleanup] Replaces NULL -> nullptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Vaclav's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_generation_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 03e1ae753f1d2dda9e5660e03c90eef243a70683..b9bab138a5e526e4e712ebda03c64ea0f6e0bd3b 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -57,7 +57,7 @@ void ReportMetrics(bool password_manager_enabled,

ran_once = true;

PasswordStore* store = client->GetPasswordStore();

- // May be NULL in tests.

+ // May be null in tests.

if (store) {

store->ReportMetrics(client->GetSyncUsername(),

client->IsPasswordSyncEnabled(

@@ -647,7 +647,7 @@ void PasswordManager::PossiblyInitializeUsernamesExperiment(

"Disabled",

2013, 12, 31,

base::FieldTrial::ONE_TIME_RANDOMIZED,

- NULL));

+ nullptr));

base::FieldTrial::Probability enabled_probability =

client_->GetProbabilityForExperiment(kOtherPossibleUsernamesExperiment);

trial->AppendGroup("Enabled", enabled_probability);