Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 951523002: Remove PaintingData from LightSource (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
Stephen White
CC:
blink-reviews, Dominik Röttsches, krit, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove PaintingData from LightSource Remove this datastructure that is not being used anymore by the filter code. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -119 lines) Patch
M Source/platform/graphics/filters/DistantLightSource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/DistantLightSource.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/platform/graphics/filters/LightSource.h View 2 chunks +0 lines, -23 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL. I guess this is not needed anymore because of Skia.
5 years, 10 months ago (2015-02-23 16:46:08 UTC) #2
rwlbuis
On 2015/02/23 16:46:08, rwlbuis wrote: > PTAL. I guess this is not needed anymore because ...
5 years, 10 months ago (2015-02-25 20:39:04 UTC) #3
Stephen White
LGTM. Thanks for the cleanup!
5 years, 10 months ago (2015-02-25 21:13:21 UTC) #4
rwlbuis
On 2015/02/25 21:13:21, Stephen White wrote: > LGTM. Thanks for the cleanup! No problem, thanks ...
5 years, 10 months ago (2015-02-25 21:23:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/951523002/1
5 years, 10 months ago (2015-02-25 21:24:34 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:23:43 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190870

Powered by Google App Engine
This is Rietveld 408576698