Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: Source/platform/graphics/filters/LightSource.h

Issue 951523002: Remove PaintingData from LightSource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/filters/LightSource.h
diff --git a/Source/platform/graphics/filters/LightSource.h b/Source/platform/graphics/filters/LightSource.h
index 78ed64941f558c4f5157a8a0c54863559feb4014..340a7915606d70ae1afde54968cb57e055615bd8 100644
--- a/Source/platform/graphics/filters/LightSource.h
+++ b/Source/platform/graphics/filters/LightSource.h
@@ -41,24 +41,6 @@ class TextStream;
class PLATFORM_EXPORT LightSource : public RefCounted<LightSource> {
public:
-
- // Light vectors must be calculated for every pixel during
- // painting. It is expensive to pass all these arguments to
- // a frequently called function, especially because not all
- // light sources require all of them. Instead, we just pass
- // a reference to the following structure
- struct PaintingData {
- // SVGFELighting also use them
- FloatPoint3D lightVector;
- FloatPoint3D colorVector;
- float lightVectorLength;
- // Private members
- FloatPoint3D directionVector;
- FloatPoint3D privateColorVector;
- float coneCutOffLimit;
- float coneFullLight;
- };
-
LightSource(LightType type)
: m_type(type)
{ }
@@ -70,11 +52,6 @@ public:
virtual PassRefPtr<LightSource> create(const FloatPoint3D& scale, const FloatSize& offset) const = 0;
- virtual void initPaintingData(PaintingData&) const = 0;
- // z is a float number, since it is the alpha value scaled by a user
- // specified "surfaceScale" constant, which type is <number> in the SVG standard
- virtual void updatePaintingData(PaintingData&, int x, int y, float z) const = 0;
-
virtual bool setAzimuth(float) { return false; }
virtual bool setElevation(float) { return false; }
virtual bool setPosition(const FloatPoint3D&) { return false; }
« no previous file with comments | « Source/platform/graphics/filters/DistantLightSource.cpp ('k') | Source/platform/graphics/filters/PointLightSource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698