Source/platform/graphics/filters/DistantLightSource.cpp - Issue 951523002: Remove PaintingData from LightSource

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/filters/DistantLightSource.cpp

Issue 951523002: Remove PaintingData from LightSource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/graphics/filters/DistantLightSource.cpp

diff --git a/Source/platform/graphics/filters/DistantLightSource.cpp b/Source/platform/graphics/filters/DistantLightSource.cpp

index 30058e42f97290ce61b127a54431a2cae37f104e..33792d3b358cf43481a823a4f4692ae710f7d9d6 100644

--- a/Source/platform/graphics/filters/DistantLightSource.cpp

+++ b/Source/platform/graphics/filters/DistantLightSource.cpp

@@ -35,20 +35,6 @@

namespace blink {

-void DistantLightSource::initPaintingData(PaintingData& paintingData) const

- float azimuth = deg2rad(m_azimuth);

- float elevation = deg2rad(m_elevation);

- paintingData.lightVector.setX(cosf(azimuth) * cosf(elevation));

- paintingData.lightVector.setY(sinf(azimuth) * cosf(elevation));

- paintingData.lightVector.setZ(sinf(elevation));

- paintingData.lightVectorLength = 1;

-void DistantLightSource::updatePaintingData(PaintingData&, int, int, float) const

bool DistantLightSource::setAzimuth(float azimuth)

{

if (m_azimuth == azimuth)